* [dpdk-dev] [PATCH] fix documentation error on debug functions
@ 2016-09-02 11:01 Mauricio Vasquez B
2016-09-26 12:28 ` Mcnamara, John
0 siblings, 1 reply; 3+ messages in thread
From: Mauricio Vasquez B @ 2016-09-02 11:01 UTC (permalink / raw)
To: dev; +Cc: stephen
Previous patch updated the functions without updating all the comments.
Fixes: 591a9d7985c1 ("add FILE argument to debug functions")
Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
---
lib/librte_eal/common/include/rte_malloc.h | 2 +-
lib/librte_eal/common/include/rte_memory.h | 2 +-
lib/librte_eal/common/include/rte_memzone.h | 2 +-
lib/librte_eal/common/include/rte_tailq.h | 2 +-
lib/librte_mbuf/rte_mbuf.h | 2 +-
lib/librte_mempool/rte_mempool.h | 2 +-
lib/librte_ring/rte_ring.h | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_malloc.h b/lib/librte_eal/common/include/rte_malloc.h
index 74bb78c..008ce13 100644
--- a/lib/librte_eal/common/include/rte_malloc.h
+++ b/lib/librte_eal/common/include/rte_malloc.h
@@ -294,7 +294,7 @@ rte_malloc_get_socket_stats(int socket,
/**
* Dump statistics.
*
- * Dump for the specified type to the console. If the type argument is
+ * Dump for the specified type to a file. If the type argument is
* NULL, all memory types will be dumped.
*
* @param f
diff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/common/include/rte_memory.h
index d9e8c21..526cfba 100644
--- a/lib/librte_eal/common/include/rte_memory.h
+++ b/lib/librte_eal/common/include/rte_memory.h
@@ -158,7 +158,7 @@ phys_addr_t rte_mem_virt2phy(const void *virt);
const struct rte_memseg *rte_eal_get_physmem_layout(void);
/**
- * Dump the physical memory layout to the console.
+ * Dump the physical memory layout to a file.
*
* @param f
* A pointer to a file for output
diff --git a/lib/librte_eal/common/include/rte_memzone.h b/lib/librte_eal/common/include/rte_memzone.h
index dae98f5..ddd48f1 100644
--- a/lib/librte_eal/common/include/rte_memzone.h
+++ b/lib/librte_eal/common/include/rte_memzone.h
@@ -275,7 +275,7 @@ int rte_memzone_free(const struct rte_memzone *mz);
const struct rte_memzone *rte_memzone_lookup(const char *name);
/**
- * Dump all reserved memzones to the console.
+ * Dump all reserved memzones to a file.
*
* @param f
* A pointer to a file for output
diff --git a/lib/librte_eal/common/include/rte_tailq.h b/lib/librte_eal/common/include/rte_tailq.h
index cc3c0f1..3a623bf 100644
--- a/lib/librte_eal/common/include/rte_tailq.h
+++ b/lib/librte_eal/common/include/rte_tailq.h
@@ -107,7 +107,7 @@ struct rte_tailq_elem {
RTE_TAILQ_CAST(rte_eal_tailq_lookup(name), struct_name)
/**
- * Dump tail queues to the console.
+ * Dump tail queues to a file.
*
* @param f
* A pointer to a file for output
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 7ea66ed..09a5253 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1989,7 +1989,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail
}
/**
- * Dump an mbuf structure to the console.
+ * Dump an mbuf structure to a file.
*
* Dump all fields for the given packet mbuf and all its associated
* segments (in the case of a chained buffer).
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 059ad9e..4744482 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -946,7 +946,7 @@ uint32_t rte_mempool_mem_iter(struct rte_mempool *mp,
rte_mempool_mem_cb_t *mem_cb, void *mem_cb_arg);
/**
- * Dump the status of the mempool to the console.
+ * Dump the status of the mempool to a file.
*
* @param f
* A pointer to a file for output
diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index 0e22e69..d461f17 100644
--- a/lib/librte_ring/rte_ring.h
+++ b/lib/librte_ring/rte_ring.h
@@ -341,7 +341,7 @@ void rte_ring_free(struct rte_ring *r);
int rte_ring_set_water_mark(struct rte_ring *r, unsigned count);
/**
- * Dump the status of the ring to the console.
+ * Dump the status of the ring to a file.
*
* @param f
* A pointer to a file for output
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fix documentation error on debug functions
2016-09-02 11:01 [dpdk-dev] [PATCH] fix documentation error on debug functions Mauricio Vasquez B
@ 2016-09-26 12:28 ` Mcnamara, John
2016-10-13 19:27 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Mcnamara, John @ 2016-09-26 12:28 UTC (permalink / raw)
To: Mauricio Vasquez B, dev; +Cc: stephen
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mauricio Vasquez B
> Sent: Friday, September 2, 2016 12:02 PM
> To: dev@dpdk.org
> Cc: stephen@networkplumber.org
> Subject: [dpdk-dev] [PATCH] fix documentation error on debug functions
>
> Previous patch updated the functions without updating all the comments.
>
> Fixes: 591a9d7985c1 ("add FILE argument to debug functions")
>
> Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
Well spotted.
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fix documentation error on debug functions
2016-09-26 12:28 ` Mcnamara, John
@ 2016-10-13 19:27 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-10-13 19:27 UTC (permalink / raw)
To: Mauricio Vasquez B; +Cc: dev, Mcnamara, John, stephen
2016-09-26 12:28, Mcnamara, John:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mauricio Vasquez B
> > Sent: Friday, September 2, 2016 12:02 PM
> > To: dev@dpdk.org
> > Cc: stephen@networkplumber.org
> > Subject: [dpdk-dev] [PATCH] fix documentation error on debug functions
> >
> > Previous patch updated the functions without updating all the comments.
> >
> > Fixes: 591a9d7985c1 ("add FILE argument to debug functions")
> >
> > Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
>
> Well spotted.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-13 19:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-02 11:01 [dpdk-dev] [PATCH] fix documentation error on debug functions Mauricio Vasquez B
2016-09-26 12:28 ` Mcnamara, John
2016-10-13 19:27 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).