DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] scripts: ignore bit macro in checkpatch
@ 2016-04-19 13:16 Thomas Monjalon
  2016-05-24 14:26 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2016-04-19 13:16 UTC (permalink / raw)
  To: dev

It was suggesting to use a Linux macro:
CHECK:BIT_MACRO: Prefer using the BIT macro

It is ignored because it is a false positive in DPDK case.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh
index 5c58a20..4cae86d 100755
--- a/scripts/checkpatches.sh
+++ b/scripts/checkpatches.sh
@@ -42,7 +42,7 @@ options="--no-tree"
 options="$options --max-line-length=$length"
 options="$options --show-types"
 options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
-VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,\
+VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,BIT_MACRO,\
 SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
 NEW_TYPEDEFS,COMPARISON_TO_NULL"
 
-- 
2.7.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] scripts: ignore bit macro in checkpatch
  2016-04-19 13:16 [dpdk-dev] [PATCH] scripts: ignore bit macro in checkpatch Thomas Monjalon
@ 2016-05-24 14:26 ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-05-24 14:26 UTC (permalink / raw)
  To: dev

2016-04-19 15:16, Thomas Monjalon:
> It was suggesting to use a Linux macro:
> CHECK:BIT_MACRO: Prefer using the BIT macro
> 
> It is ignored because it is a false positive in DPDK case.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

By the way, maybe that someone would like to implement RTE_BIT?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH] scripts: ignore bit macro in checkpatch
@ 2016-04-19 13:15 Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-04-19 13:15 UTC (permalink / raw)
  To: dev

It was suggesting to use a Linux macro:
CHECK:BIT_MACRO: Prefer using the BIT macro

It is ignored because it is a false positive in DPDK case.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh
index 5c58a20..4cae86d 100755
--- a/scripts/checkpatches.sh
+++ b/scripts/checkpatches.sh
@@ -42,7 +42,7 @@ options="--no-tree"
 options="$options --max-line-length=$length"
 options="$options --show-types"
 options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
-VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,\
+VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,BIT_MACRO,\
 SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
 NEW_TYPEDEFS,COMPARISON_TO_NULL"
 
-- 
2.7.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-24 14:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-19 13:16 [dpdk-dev] [PATCH] scripts: ignore bit macro in checkpatch Thomas Monjalon
2016-05-24 14:26 ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2016-04-19 13:15 Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).