From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18D62A0C53; Wed, 1 Sep 2021 08:45:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD2C44013F; Wed, 1 Sep 2021 08:45:24 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 15B9B40041 for ; Wed, 1 Sep 2021 08:45:23 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9C15D7F523; Wed, 1 Sep 2021 09:45:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9C15D7F523 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1630478722; bh=aeEXuoWKfsbobwKNkJzQJZR/aUoraMwIF1Ui92mPVVI=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=R41ZZYTTUcjUSqxHsO8tOS+2F/OKdV6IjCdIcZOSltVNLQ2Ihma/Qni+PMxf+TdBX Cxj4NRoH9XYzEAOZ+YsCyWpdKW8058UOWT5Qd/U0HQioF7Ghwa5QkkMH9kggN2NwJ7 ZCLHGMcZTrjJXK0x1Kclu9p2usTnPfBc1+sepw6M= To: Stephen Hemminger , dev@dpdk.org Cc: konstantin.ananyev@intel.com References: <20210825220958.91326-1-stephen@networkplumber.org> <20210831193507.43426-1-stephen@networkplumber.org> <20210831193507.43426-4-stephen@networkplumber.org> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <332aeaa2-b72d-b59e-74f8-0f7f3c2d0993@oktetlabs.ru> Date: Wed, 1 Sep 2021 09:45:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210831193507.43426-4-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/31/21 10:35 PM, Stephen Hemminger wrote: > This function should be made stable now. > > Also, fix the docbook comment format. > > Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value") > Cc: konstantin.ananyev@intel.com > Signed-off-by: Stephen Hemminger I'm not sure that it is correct to have promotion with Fixes tag. It will require extra care on backporting to stable. Acked-by: Andrew Rybchenko > --- > lib/mbuf/rte_mbuf.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h > index 7722b36ee44b..627790fe26e7 100644 > --- a/lib/mbuf/rte_mbuf.h > +++ b/lib/mbuf/rte_mbuf.h > @@ -1773,7 +1773,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail > return 0; > } > > -/* > +/** > * @warning > * @b EXPERIMENTAL: This API may change without prior notice. The warning must be removed. > * > @@ -1797,6 +1797,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail > * @return > * raw tx_offload value. > */ > +__rte_experimental > static __rte_always_inline uint64_t > rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t tso, > uint64_t ol3, uint64_t ol2, uint64_t unused) >