From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBC24A0597; Fri, 17 Apr 2020 18:22:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FF3D1EADD; Fri, 17 Apr 2020 18:19:54 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E76A11EA72 for ; Fri, 17 Apr 2020 18:19:43 +0200 (CEST) IronPort-SDR: U5EJ7bkEBcCe7S260YfoNvvQKnY6Xv4JpRZPmA47A/pJ5QUSMp/+ip/Dfjfxay05dz6M7Ln/79 ZU+ihrMjjc7g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 09:19:42 -0700 IronPort-SDR: FvvwO2D450OFCoOIFHCcGVqNkrkRFLMUO+fEBB9Kar7UvKulOF4BJZm/xq5wbSpy4sWqWWBxyL oeSzaqjPMOGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,395,1580803200"; d="scan'208";a="278428291" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.209.17]) ([10.213.209.17]) by fmsmga004.fm.intel.com with ESMTP; 17 Apr 2020 09:19:39 -0700 To: Thomas Monjalon Cc: Matan Azrad , Raslan Darawsheh , Ophir Munk , David Marchand , "dev@dpdk.org" , Olga Shern , Asaf Penso , "Kinsella, Ray" , Neil Horman , Kevin Laatz , hemant.agrawal@nxp.com, Haiyue Wang , Sunil Kumar Kori References: <20200329223222.7553-1-ophirmu@mellanox.com> <54f82543-e53e-98dd-bcc8-cb3669933fa5@intel.com> <15233448.O6BkTfRZtg@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <3331df24-e56b-fca4-57ca-76af3714a688@intel.com> Date: Fri, 17 Apr 2020 17:19:38 +0100 MIME-Version: 1.0 In-Reply-To: <15233448.O6BkTfRZtg@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/16/2020 9:00 PM, Thomas Monjalon wrote: > 16/04/2020 19:35, Ferruh Yigit: >> On 4/9/2020 8:24 AM, David Marchand wrote: >>> On Wed, Apr 8, 2020 at 7:12 PM Ferruh Yigit wrote: >>>> On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: >>>>> From: Ophir Munk >>>>>> >>>>>> File mlx5_devx_cmds.c should contain pure DevX calls. It must be OS >>>>>> agnostic and not include any references to ibv or dv structs (defined in >>>>>> ibverbs and rdma-core linux libraries). This commit replaces all ibv and >>>>>> dv references with 'void *'. Specifically, the following struct were >>>>>> replaced: >>>>>> 1. struct ibv_context * >>>>>> 2. struct ibv_qp * >>>>>> 3. struct mlx5dv_devx_cmd_comp * >>>>>> >>>>>> Signed-off-by: Ophir Munk >>>>> >>>>> Patch applied to next-net-mlx, >>>>> >>>> >>>> Hi David, >>>> >>>> This patch is failing in the travis for ABI checks [1], since mlx has APIs now >>>> [2], are they public APIs or internal ones, and are they part of the ABI policy, >>>> can you please check this? >>> >>> - What I see on patchwork and test-report ml for this patch: >>> http://patchwork.dpdk.org/patch/67367/ >>> >>> Ophir proposed a patch on 03/30. >>> >>> The robot reported an issue on 03/30, and I suppose Ophir got a report. >>> https://mails.dpdk.org/archives/test-report/2020-March/122623.html >>> https://travis-ci.com/github/ovsrobot/dpdk/jobs/308057800#L2337 >>> >>> Matan acked the patch on 03/31. >>> >>> Rasland merged the patch on 04/01. >>> >>> I understand that the abi checks are not perfect, and people need help >>> with the new abi checks. >>> Prove me wrong, but here, I get the feeling that it was just ignored >>> by 3 people in a row. >>> >>> - On the question if these should be public API or internal, that is >>> not for me to reply/investigate. >>> This is a question for Mellanox. >>> >> >> Hi Matan, Raslan, Ophir, >> >> First can you please clarify if these APIs are internal or public? > > As most of common drivers, some functions are exported to be > used by some PMDs. So they are not part of the API/ABI and should be skipped > by ABI checks. > >> And later if the ABI break issue is not clarified I may need to drop these >> patches. Right now they fail in travis! > > Yes, it fails and could it be avoided with some libabigail config. > But the real solution is to mark internal symbols, and we are waiting > for rte_internal patchset to be completed and merged. > > Ferruh, please let's not bloat libabigail config, > and reject any patch failing ABI checks. > > As a consequence, this patch must be dropped until it uses rte_internal. > Thanks > > dropped the patch from next-net and updated its patchwork status.