DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Asaf Penso <asafp@nvidia.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: add new tables for rte flow items and actions support
Date: Thu, 04 Feb 2021 23:09:21 +0100	[thread overview]
Message-ID: <3332710.vYT52BTSvG@thomas> (raw)
In-Reply-To: <1612458325-13508-1-git-send-email-asafp@nvidia.com>

04/02/2021 18:05, Asaf Penso:
> In http://doc.dpdk.org/guides/nics/overview.html, table 1.1 lists all
> supported features.
> It has a single line for "Flow API" that refers to rte_flow support.
> rte_flow is composed of many items and actions that are not expressed in
> this single line.
> 
> The following new tables are suggested:
> 1. rte_flow items
> 2. rte_flow actions
> 3. rte_flow shared actions
> 
> Signed-off-by: Asaf Penso <asafp@nvidia.com>
> ---
>  doc/guides/conf.py                   |  23 +++++---
>  doc/guides/nics/features/default.ini | 109 +++++++++++++++++++++++++++++++++++
>  doc/guides/nics/features/mlx4.ini    |  15 +++++
>  doc/guides/nics/features/mlx5.ini    |  70 ++++++++++++++++++++++
>  doc/guides/nics/overview.rst         |  11 ++++
>  5 files changed, 221 insertions(+), 7 deletions(-)

After running git status I remembered the generated .txt files
must be added in .gitignore.

[...]
> +[rte_flow actions]
> +end                  = Y
> +void                 = Y
> +jump                 = Y
> +mark                 = Y
> +flag                 = Y
> +queue                = Y
> +drop                 = Y
> +count                = Y
> +rss                  = Y
> +port_id              = Y
> +meter                = Y
> +of_pop_vlan          = Y
> +of_push_vlan         = Y
> +of_set_vlan_vid      = Y
> +of_set_vlan_pcp      = Y
> +vxlan_encap          = Y
> +vxlan_decap          = Y
> +raw_encap            = Y
> +raw_decap            = Y
> +set_ipv4_src         = Y
> +set_ipv4_dst         = Y
> +set_ipv6_src         = Y
> +set_ipv6_dst         = Y
> +set_tp_src           = Y
> +set_tp_dst           = Y
> +dec_ttl              = Y
> +set_ttl              = Y
> +set_mac_src          = Y
> +set_mac_dst          = Y
> +inc_tcp_seq          = Y
> +dec_tcp_seq          = Y
> +inc_tcp_ack          = Y
> +dec_tcp_ack          = Y
> +set_tag              = Y
> +set_meta             = Y
> +set_ipv4_dscp        = Y
> +set_ipv6_dscp        = Y
> +age                  = Y
> +sample               = Y
> +shared               = S
> +modify_field         = Y

I suggest not having "shared" in above table but marking "age" and "rss"
as shared with "S" in above table.

> +[rte_flow shared actions]
> +age                  = Y
> +rss                  = Y




  reply	other threads:[~2021-02-04 22:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 17:05 Asaf Penso
2021-02-04 22:09 ` Thomas Monjalon [this message]
2021-02-07  8:46   ` Asaf Penso
2021-02-07  9:44     ` Thomas Monjalon
2021-02-07  9:27 ` [dpdk-dev] [PATCH v2] " Asaf Penso
2021-02-07 10:46   ` [dpdk-dev] [PATCH v3] " Asaf Penso
2021-02-07 10:52     ` [dpdk-dev] [PATCH v4] " Asaf Penso
2021-02-08 12:58       ` Thomas Monjalon
2021-02-16 13:13       ` Ferruh Yigit
2021-02-17  5:57         ` Asaf Penso
2021-02-17 10:37           ` Ferruh Yigit
2021-02-17 10:49             ` Thomas Monjalon
2021-02-18 16:12               ` Asaf Penso
2021-02-18 17:58               ` Ajit Khaparde
2021-02-18 18:45                 ` Ferruh Yigit
2021-04-06 15:07                   ` Thomas Monjalon
2021-04-07 22:33 ` [dpdk-dev] [PATCH v5 0/3] rte_flow doc matrix Thomas Monjalon
2021-04-07 22:33   ` [dpdk-dev] [PATCH v5 1/3] doc: rename sfc features file Thomas Monjalon
2021-04-07 22:33   ` [dpdk-dev] [PATCH v5 2/3] doc: add flow API features tables Thomas Monjalon
2021-04-08  8:45     ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2021-05-14 10:42     ` [dpdk-dev] " Ferruh Yigit
2021-05-14 11:52       ` Thomas Monjalon
2021-04-07 22:33   ` [dpdk-dev] [PATCH v5 3/3] devtools: check flow API doc tables Thomas Monjalon
2021-05-13 18:40     ` Ferruh Yigit
2021-05-18 12:46       ` Thomas Monjalon
2021-05-14 10:51     ` Ferruh Yigit
2021-05-18 10:33       ` Thomas Monjalon
2021-05-18 13:28 ` [dpdk-dev] [PATCH v6 0/3] rte_flow doc matrix Thomas Monjalon
2021-05-18 13:28   ` [dpdk-dev] [PATCH v6 1/3] doc: rename sfc features file Thomas Monjalon
2021-05-18 13:28   ` [dpdk-dev] [PATCH v6 2/3] doc: add flow API features tables Thomas Monjalon
2021-05-18 13:28   ` [dpdk-dev] [PATCH v6 3/3] devtools: check flow API doc tables Thomas Monjalon
2021-05-18 16:54   ` [dpdk-dev] [PATCH v6 0/3] rte_flow doc matrix Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3332710.vYT52BTSvG@thomas \
    --to=thomas@monjalon.net \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).