From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id E20911B162
 for <dev@dpdk.org>; Mon, 18 Sep 2017 16:57:34 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 18 Sep 2017 07:57:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="1173321163"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57])
 ([10.237.220.57])
 by orsmga001.jf.intel.com with ESMTP; 18 Sep 2017 07:57:32 -0700
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Cc: hemant.agrawal@nxp.com
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-42-shreyansh.jain@nxp.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <3332a9da-5e28-260a-68fa-ab665f907403@intel.com>
Date: Mon, 18 Sep 2017 15:57:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170909112132.13936-42-shreyansh.jain@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v4 41/41] net/dpaa: support for extended
	statistics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 14:57:35 -0000

On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

<...>

> +static int
> +dpaa_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
> +		    unsigned int n)
> +{
> +	struct dpaa_if *dpaa_intf = dev->data->dev_private;
> +	unsigned int i = 0, num = RTE_DIM(dpaa_xstats_strings);
> +	uint64_t values[sizeof(struct dpaa_if_stats) / 8];
> +
> +	if (xstats == NULL)
> +		return 0;

This is a little not clear from API definition, but I guess when xstats
is NULL, it should return num of available stats, "num" for this case. I
guess there are PMDs implements both, can you please double check?

> +
> +	if (n < num)
> +		return num;
> +
> +	fman_if_stats_get_all(dpaa_intf->fif, values,
> +			      sizeof(struct dpaa_if_stats) / 8);
> +
> +	for (i = 0; i < num; i++) {
> +		xstats[i].id = i;
> +		xstats[i].value = values[dpaa_xstats_strings[i].offset / 8];
> +	}
> +	return i;
> +}

<...>