* [dpdk-dev] [PATCH] testpmd: fix typo when closing port
@ 2016-06-08 15:20 Pablo de Lara
2016-06-08 16:28 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Pablo de Lara @ 2016-06-08 15:20 UTC (permalink / raw)
To: dev; +Cc: Pablo de Lara
Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
app/test-pmd/testpmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index da74280..2738805 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1515,7 +1515,7 @@ close_port(portid_t pid)
if (rte_atomic16_cmpset(&(port->port_status),
RTE_PORT_HANDLING, RTE_PORT_CLOSED) == 0)
- printf("Port %d can not be set into stopped\n", pi);
+ printf("Port %d can not be set into closed\n", pi);
}
printf("Done\n");
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
2016-06-08 15:20 [dpdk-dev] [PATCH] testpmd: fix typo when closing port Pablo de Lara
@ 2016-06-08 16:28 ` Thomas Monjalon
2016-06-08 17:18 ` Mcnamara, John
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-06-08 16:28 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev
2016-06-08 16:20, Pablo de Lara:
> if (rte_atomic16_cmpset(&(port->port_status),
> RTE_PORT_HANDLING, RTE_PORT_CLOSED) == 0)
> - printf("Port %d can not be set into stopped\n", pi);
> + printf("Port %d can not be set into closed\n", pi);
My english would say "Port cannot be closed".
Am I wrong?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
2016-06-08 16:28 ` Thomas Monjalon
@ 2016-06-08 17:18 ` Mcnamara, John
2016-06-08 17:59 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Mcnamara, John @ 2016-06-08 17:18 UTC (permalink / raw)
To: Thomas Monjalon, De Lara Guarch, Pablo; +Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, June 8, 2016 5:29 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
>
> 2016-06-08 16:20, Pablo de Lara:
> > if (rte_atomic16_cmpset(&(port->port_status),
> > RTE_PORT_HANDLING, RTE_PORT_CLOSED) == 0)
> > - printf("Port %d can not be set into stopped\n", pi);
> > + printf("Port %d can not be set into closed\n", pi);
>
> My english would say "Port cannot be closed".
> Am I wrong?
Yes, that is better or "Port cannot be set to closed" if "closed" is a
state like here.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
2016-06-08 17:18 ` Mcnamara, John
@ 2016-06-08 17:59 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-06-08 17:59 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, Mcnamara, John
2016-06-08 17:18, Mcnamara, John:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > 2016-06-08 16:20, Pablo de Lara:
> > > if (rte_atomic16_cmpset(&(port->port_status),
> > > RTE_PORT_HANDLING, RTE_PORT_CLOSED) == 0)
> > > - printf("Port %d can not be set into stopped\n", pi);
> > > + printf("Port %d can not be set into closed\n", pi);
> >
> > My english would say "Port cannot be closed".
> > Am I wrong?
>
> Yes, that is better or "Port cannot be set to closed" if "closed" is a
> state like here.
Applied with John's proposal.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-08 17:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-08 15:20 [dpdk-dev] [PATCH] testpmd: fix typo when closing port Pablo de Lara
2016-06-08 16:28 ` Thomas Monjalon
2016-06-08 17:18 ` Mcnamara, John
2016-06-08 17:59 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).