From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 7CA99C134
 for <dev@dpdk.org>; Wed,  8 Jun 2016 19:59:12 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id n184so192747130wmn.1
 for <dev@dpdk.org>; Wed, 08 Jun 2016 10:59:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=zRJaZa8xPqCTAGgt2LSRdrwiNYq9IOHC0bUtgt7OG40=;
 b=Q/NAvkbs9YLtwe97XvgRgGHOvRSlgBSzcf2TLrnuPxBHPzJJ5nfjzXAU7qN0lOveyB
 Ax/Lu9z3N/6VPlnzezKvLUcI3S0QhobIJ1cBGV1dgmuxCyvAl7dPZwmQzsvSVRZbUTjs
 DvW0TczKvSt/m7C6t/Nz8IlRRQ5Of+uwVa9UMtbhbOY8km/zRg+fMJTv8Tw6kqUs+NmS
 mWLfAvg9Sj6I9Tk4i52ludHAOCfR5n+U1Rf1PRvN5aY8feyxpAgme5GsgY5YiVnFsniH
 3m6OR+Yy3tVEUM0QcKe5sSrylGiHnQtYsUvbQbTDrW3bjClqTkCVQ0vnEiuxqs4Wd0PE
 yuzQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=zRJaZa8xPqCTAGgt2LSRdrwiNYq9IOHC0bUtgt7OG40=;
 b=AbMEr3d1/QilVnYEzaCPHWQhI8SCZslsxnXv62LiOPdV55zDXv6umguv5qTAsRHQqw
 rlumTt/3oSdl93nKMjd2XA67jh/cnqOZMX54rKWe1RZtJ/DO5T8JviAMgnL9RDbXPzqa
 M1abVEyQKD1tb0/5DKAeFq0TJ5hurJ9JKn8IoJUCYVnDQ6eTPi5uuOYKYRtCr/iutsur
 XNtvkhXf5JBceo7dC522Tgb0evrmpS51GUSliVYcWV3UbPAnOQpXXYOm74tHRBnMDbsL
 M5tr7kNH63gpto6pI9aE1HMZrpwM3vzqL8MSpGAjvpwesnD/7RCjIoA2/W/XwDa/Cfy6
 Z69A==
X-Gm-Message-State: ALyK8tKzIsO1yVob3ZC9OnQSzoxBGh25aoRwYATzl/WpnI0knihhyDji82+2szY1D/BRw0GW
X-Received: by 10.28.144.7 with SMTP id s7mr9365067wmd.103.1465408752289;
 Wed, 08 Jun 2016 10:59:12 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id u6sm2714678wjy.17.2016.06.08.10.59.11
 (version=TLSv1/SSLv3 cipher=OTHER);
 Wed, 08 Jun 2016 10:59:11 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
Date: Wed, 08 Jun 2016 19:59:10 +0200
Message-ID: <33331795.Sa6neYO5Xo@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20257DD57@IRSMSX103.ger.corp.intel.com>
References: <1465399231-7023-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <43127148.6njRUyVk9W@xps13>
 <B27915DBBA3421428155699D51E4CFE20257DD57@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2016 17:59:12 -0000

2016-06-08 17:18, Mcnamara, John:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > 2016-06-08 16:20, Pablo de Lara:
> > >  		if (rte_atomic16_cmpset(&(port->port_status),
> > >  			RTE_PORT_HANDLING, RTE_PORT_CLOSED) == 0)
> > > -			printf("Port %d can not be set into stopped\n", pi);
> > > +			printf("Port %d can not be set into closed\n", pi);
> > 
> > My english would say "Port cannot be closed".
> > Am I wrong?
> 
> Yes, that is better or "Port cannot be set to closed" if "closed" is a
> state like here.

Applied with John's proposal.