DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] pipeline: fix instruction label check
@ 2021-10-21  3:23 Yogesh Jangra
  2021-10-25 12:06 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Yogesh Jangra @ 2021-10-21  3:23 UTC (permalink / raw)
  To: dev; +Cc: cristian.dumitrescu, venkata.suresh.kumar.p, yogesh.jangra, stable

The instruction_data array was incorrectly indexed, which resulted in
the array index getting out of bounds and sometimes segfault.

Fixes: a1711f (“pipeline: add SWX Rx and extract instructions“)
Cc: stable@dpdk.org

Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 lib/pipeline/rte_swx_pipeline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipeline.c
index 1cd09a4..0550560 100644
--- a/lib/pipeline/rte_swx_pipeline.c
+++ b/lib/pipeline/rte_swx_pipeline.c
@@ -5983,7 +5983,7 @@ struct_field_parse(struct rte_swx_pipeline *p,
 			continue;
 
 		for (j = i + 1; j < n_instructions; j++)
-			CHECK(strcmp(label, data[j].label), EINVAL);
+			CHECK(strcmp(label, instruction_data[j].label), EINVAL);
 	}
 
 	/* Get users for each instruction label. */
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] pipeline: fix instruction label check
  2021-10-21  3:23 [dpdk-dev] [PATCH] pipeline: fix instruction label check Yogesh Jangra
@ 2021-10-25 12:06 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-10-25 12:06 UTC (permalink / raw)
  To: cristian.dumitrescu, Yogesh Jangra; +Cc: dev, stable, venkata.suresh.kumar.p

21/10/2021 05:23, Yogesh Jangra:
> The instruction_data array was incorrectly indexed, which resulted in
> the array index getting out of bounds and sometimes segfault.
> 
> Fixes: a1711f (“pipeline: add SWX Rx and extract instructions“)
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-25 12:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21  3:23 [dpdk-dev] [PATCH] pipeline: fix instruction label check Yogesh Jangra
2021-10-25 12:06 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).