From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6D2D52B9A for ; Sat, 7 Oct 2017 13:37:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BAADF20A5B; Sat, 7 Oct 2017 07:37:22 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 07 Oct 2017 07:37:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=kL8c8Fse2F2HreB H5vFYjz9cODuo+aZbytPtCb6MBCU=; b=DAzllj7jMO0mz/c1UmdKDo19JyVUMIe gFmF+kFw2DDAm1+QbymVgowlFrLs7kzwX9JG8Vk24I8juE5xbVO3ZkDpfNpmBecn PKOyIke1SeQi/VjNJC5tN6mZrLqCb+4ZcvMtYatfJrmpiNCPFZXQ1DcZV8fzNPWr dDcnnElzmQJ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=kL8c8Fse2F2HreBH5vFYjz9cODuo+aZbytPtCb6MBCU=; b=gv14on7Z 6BV9EmQPI2f7gbTOnO+vd4IIhkyOdB+4r/nWTO36FkxhndRO32y0XE305262sAkn nzTrqcWAcxZcFPv+/senOjWX90zLyqGpLWCM8NPd+4Qssas2kqS3yhk3YKGXnxLr eGTRIuS2txE4hdWnY+zMPRMnTbplYAPi4EsD5nsleQE42u/Aj0PlYnCJJEN2Mwm5 JIZUnzC+9mRiDnjifkKGQAMcQCoLqsXBZYunf0q9gFa6IaKazdrnadPu6b8vGUsQ 7nPGvLCyuWv5AcZy8bcd2gl1KPyax+o2pPmGsAiq5vxeyYv1Tg/jGA7GBU7XchEh ZInqDrBE8vV6VA== X-ME-Sender: X-Sasl-enc: CwEk9cHj+e7mBLqIFh9vQ5NZbiu28bo3Nz1wkkg6N01U 1507376242 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 708E27FA5E; Sat, 7 Oct 2017 07:37:22 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal Cc: anatoly.burakov@intel.com, dev@dpdk.org Date: Sat, 07 Oct 2017 13:37:21 +0200 Message-ID: <3342808.snfueRI35B@xps> In-Reply-To: <1507375221-16271-1-git-send-email-hemant.agrawal@nxp.com> References: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com> <1507375221-16271-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: enable vfio independent of no PCI flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Oct 2017 11:37:24 -0000 07/10/2017 13:20, Hemant Agrawal: > In case no_pci is configured, other buses e.g. fslmc bus will > still need the the vfio to be enabled. > > Signed-off-by: Hemant Agrawal > --- > v2: enabled VFIO, independent of no-pci flag as suggested by Thomas [...] > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -733,10 +733,8 @@ static int rte_eal_vfio_setup(void) > { > int vfio_enabled = 0; > > - if (!internal_config.no_pci) { > - pci_vfio_enable(); > - vfio_enabled |= pci_vfio_is_enabled(); > - } > + pci_vfio_enable(); > + vfio_enabled |= pci_vfio_is_enabled(); You are enabling vfio_pci. This part could stay conditionned by no_pci. I was thinking you need vfio without vfio_pci. Am I right? If yes, I suggest to enable only vfio root module.