From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, bluca@debian.org
Subject: Re: [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file
Date: Thu, 02 May 2019 14:38:49 +0200 [thread overview]
Message-ID: <3343772.7GDin1kDO3@xps> (raw)
In-Reply-To: <20190426165043.17268-5-bruce.richardson@intel.com>
Hi,
I will probably have a ton of comments about adding a new compilation tests,
and I think it is a bit late for such an addition.
However, all the fixes should go in 19.05.
26/04/2019 18:50, Bruce Richardson:
> The pkg-config file generated as part of the build of DPDK should allow
> applications to be built with an installed DPDK. We can test this as
> part of the build by doing an install of DPDK to a temporary directory
> within the build folder, and by then compiling up a few sample apps
> using make working off that directory.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Luca Boccassi <bluca@debian.org>
> ---
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> +##############
> +# Test installation of the x86-default target, to be used for checking
> +# the sample apps build using the pkg-config file for cflags and libs
> +###############
I would prefer simpler comment formatting.
It makes this test very special.
> +build_path=build-x86-default
> +DESTDIR=`pwd`/$build_path/install-root ; export DESTDIR
export DESTDIR=... is not supported everywhere?
I prefer new shell substitution syntax $() instead of backquotes.
> +$ninja_cmd -C $build_path install
> +
> +pc_file=$(find $DESTDIR -name libdpdk.pc)
> +PKG_CONFIG_PATH=$(dirname $pc_file) ; export PKG_CONFIG_PATH
> +
> +# rather than hacking our environment, just edit the .pc file prefix value
> +sed -i -e "s|prefix=|prefix=$DESTDIR|" $pc_file
What is the alternative?
Cannot we configure meson with the right prefix?
> +for example in helloworld l2fwd l3fwd skeleton timer; do
> + echo "## Building $example"
> + $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example
> +done
> +
> +echo ""
> +echo "## $0: Completed OK"
This last log is uncommon.
next prev parent reply other threads:[~2019-05-02 12:38 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 22:06 [dpdk-dev] [PATCH 0/4] add testing of libdpdk " Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 1/4] examples: install examples as part of ninja install Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 2/4] examples: simplify getting list of all examples Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-24 9:22 ` Luca Boccassi
2019-04-24 9:22 ` Luca Boccassi
2019-04-24 10:41 ` Bruce Richardson
2019-04-24 10:41 ` Bruce Richardson
2019-04-24 11:02 ` Luca Boccassi
2019-04-24 11:02 ` Luca Boccassi
2019-04-24 12:31 ` Bruce Richardson
2019-04-24 12:31 ` Bruce Richardson
2019-04-24 13:37 ` Luca Boccassi
2019-04-24 13:37 ` Luca Boccassi
2019-04-26 14:56 ` Bruce Richardson
2019-04-26 14:56 ` Bruce Richardson
2019-04-26 16:10 ` Luca Boccassi
2019-04-26 16:10 ` Luca Boccassi
2019-05-02 13:11 ` Thomas Monjalon
2019-05-02 13:11 ` Thomas Monjalon
2019-05-02 13:17 ` Bruce Richardson
2019-05-02 13:17 ` Bruce Richardson
2019-05-02 14:08 ` Luca Boccassi
2019-05-02 14:08 ` Luca Boccassi
2019-05-02 15:11 ` Thomas Monjalon
2019-05-02 15:11 ` Thomas Monjalon
2019-05-02 15:30 ` Bruce Richardson
2019-05-02 15:30 ` Bruce Richardson
2019-05-02 15:38 ` Thomas Monjalon
2019-05-02 15:38 ` Thomas Monjalon
2019-05-02 15:41 ` Bruce Richardson
2019-05-02 15:41 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 4/4] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 23:04 ` [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file Stephen Hemminger
2019-04-23 23:04 ` Stephen Hemminger
2019-04-24 8:54 ` Bruce Richardson
2019-04-24 8:54 ` Bruce Richardson
2019-04-24 9:00 ` Bruce Richardson
2019-04-24 9:00 ` Bruce Richardson
2019-04-26 16:11 ` Luca Boccassi
2019-04-26 16:11 ` Luca Boccassi
2019-04-26 16:20 ` Bruce Richardson
2019-04-26 16:20 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 0/6] " Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 1/6] examples/l3fwd: fix compile on FreeBSD Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 2/6] examples: install examples as part of ninja install Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 3/6] build: fix ninja install on FreeBSD Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-02 12:38 ` Thomas Monjalon [this message]
2019-05-02 12:38 ` Thomas Monjalon
2019-05-02 12:54 ` Luca Boccassi
2019-05-02 12:54 ` Luca Boccassi
2019-05-02 13:21 ` Bruce Richardson
2019-05-02 13:21 ` Bruce Richardson
2019-05-02 13:57 ` Thomas Monjalon
2019-05-02 13:57 ` Thomas Monjalon
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 5/6] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 6/6] examples: remove auto-generation of examples list Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 0/4] file meson compilation and install issues Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 1/4] examples/l3fwd: fix compile on FreeBSD Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 2/4] examples: install examples as part of ninja install Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 3/4] build: fix ninja install on FreeBSD Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 4/4] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 21:09 ` [dpdk-dev] [PATCH v4 0/4] file meson compilation and install issues Thomas Monjalon
2019-05-02 21:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3343772.7GDin1kDO3@xps \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).