From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C0373A84C for <dev@dpdk.org>; Sun, 21 Jan 2018 21:28:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2018 12:28:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,393,1511856000"; d="scan'208";a="11889768" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.26.249]) ([10.252.26.249]) by orsmga008.jf.intel.com with ESMTP; 21 Jan 2018 12:28:10 -0800 To: Matan Azrad <matan@mellanox.com>, Adrien Mazarguil <adrien.mazarguil@6wind.com>, Gaetan Rivet <gaetan.rivet@6wind.com> Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org References: <1516274834-19755-1-git-send-email-matan@mellanox.com> <1516482744-8415-1-git-send-email-matan@mellanox.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <334636fe-62e9-e51d-055a-b8369478eff7@intel.com> Date: Sun, 21 Jan 2018 20:28:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516482744-8415-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 0/6] Fail-safe\ethdev: fix removal handling lack X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sun, 21 Jan 2018 20:28:13 -0000 On 1/20/2018 9:12 PM, Matan Azrad wrote: > There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. > At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. > > This series adds new ethdev operation to check device removal, adds support for it in mlx PMDs, adjust ethdev APIs to return -EIO in case of removal and fixes the fail-safe bug of removal error report. > > V2: > Remove ENODEV definition. > Remove checks from all mlx control commands. > Add new devop - "is_removed". > Implement it in mlx4 and mlx5. > Fix failsafe bug by the new devop. > > V3: > Adjust ethdev APIs removal error report. > Change failsafe check to check eth_dev* return values. > Remove backporting of fail-safe patch. > > V4: > Improve fail-safe internal API to adjust the actual error value as discussed. > Remove "Fixes" lines from fail-safe patch. > No changes in ethdev\mlx patches. > > V5: > Rebase on top of master-net-mlx. > > V6: > Move ethdev new API to be EXPERIMENTAL. > > V7: > Fix API return value description. > Swap checks in the new API as Konstantin suggested. > Add comment in the API as Ferruh suggested. > > Matan Azrad (6): > ethdev: add devop to check removal status > net/mlx4: support a device removal check operation > net/mlx5: support a device removal check operation > ethdev: adjust APIs removal error report > ethdev: adjust flow APIs removal error report > net/failsafe: fix removed device handling Series applied to dpdk-next-net/master, thanks.