From: Thomas Monjalon <thomas@monjalon.net>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
"Trybula, ArturX" <arturx.trybula@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"shallyv@marvell.com" <shallyv@marvell.com>,
"Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
"Danilewicz, MarcinX" <marcinx.danilewicz@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector
Date: Fri, 17 Jan 2020 22:51:30 +0100 [thread overview]
Message-ID: <3347026.0YcMNavOfZ@xps> (raw)
In-Reply-To: <VE1PR04MB66390D487BCA1D294FA98261E6370@VE1PR04MB6639.eurprd04.prod.outlook.com>
15/01/2020 16:54, Akhil Goyal:
> > >
> > > This patch replaces existing test vector with a new
> > > one containing C code to fix license issue.
> > >
> > > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> Applied to dpdk-next-crypto
This is a terrible idea.
Adding C code in a C project as text, and worst, its own code,
will make grep matching on fake text.
Why do you need so much text to compress?
Why not just opening our own code files as text?
Why stable@dpdk.org is Cc'ed in this email?
What is the license issue?
Should it be backported? If yes, the stable tag is missing.
I drop this patch from -rc1.
next prev parent reply other threads:[~2020-01-17 21:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 11:56 [dpdk-dev] " Artur Trybula
2020-01-14 12:33 ` Trahe, Fiona
2020-01-15 15:54 ` Akhil Goyal
2020-01-17 21:51 ` Thomas Monjalon [this message]
2020-01-20 13:54 ` [dpdk-dev] [dpdk-stable] " Mcnamara, John
2020-01-20 14:33 ` Thomas Monjalon
2020-01-20 15:00 ` Trahe, Fiona
2020-01-20 18:00 ` Mcnamara, John
2020-01-27 10:59 ` Mcnamara, John
2020-02-06 9:37 ` [dpdk-dev] [PATCH v2] " Artur Trybula
2020-02-12 13:25 ` Akhil Goyal
2020-02-12 13:31 ` Thomas Monjalon
2020-02-12 14:12 ` Akhil Goyal
2020-02-12 14:56 ` Trybula, ArturX
2020-02-13 9:30 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3347026.0YcMNavOfZ@xps \
--to=thomas@monjalon.net \
--cc=adamx.dybkowski@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=arturx.trybula@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=marcinx.danilewicz@intel.com \
--cc=shallyv@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).