From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 633D74C99 for <dev@dpdk.org>; Mon, 22 Oct 2018 15:08:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F3B5B21F32; Mon, 22 Oct 2018 09:08:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Oct 2018 09:08:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0R6+aCiX9/zA7lJqsW99kUfJLzzgbIZiXjaREYxKKtE=; b=mJ/SMlTJdxIx CdVh7JbFCSdvWOM4We0HO8uQmFHGwLOEeXU5zs436fySHJw6HruqQOTkXaCfHtzD uSjbxhiC0G+5dA3Hk+eDlxnTSbZfxyw/q9/vKU5nnBaVdG0q2oyKpYTTNY1Iehyp nxWWhwqeHbZEtzp+t/j/SHXgPRC6rg0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=0R6+aCiX9/zA7lJqsW99kUfJLzzgbIZiXjaREYxKK tE=; b=ktOpxcCGTtcPCrvLWtI+u1sidVznRIBTQIdaJIU/D3TwtUV36ins2IX4R mqBlCmYQF0U9c2BKKHahcCFAQy9SPdohwwJZaWrE7UkMPhv9nWtgBqiz/rkA1/3A N32PtfuzVnU0qzLwkeH8MBuJHEgsFAdGmH1J/FpJitnzmDVjahemPhMTl6Z3DyqE XtqlP1QhwydkRjy1XfdiMBAVScon66shee+WP4uB1PlI9JQXI5ZNgKmyKfjzyhyY /K0TmE9qYd8CkLYyHDbpa8QUOlU04D8HHN7msItRXMBnSUee4svfhSXL766hXRtJ 0XtEB76kd/4Y7RuKzNiD0JWqkOM5w== X-ME-Sender: <xms:tcvNW_PROQMl2yUEI8hdOv0kq0pXuQ3WuiFNqhWtzmdXpcwORj5XHg> X-ME-Proxy: <xmx:tcvNW6Okw2inM8s8lK8b9dIyKgBOCAMg1LQSjmmKGJarGbLvD3XflQ> <xmx:tcvNW3Rl-Z7bnDDJUS6Yj1FMnq1Gcys5s3ExO4cKNBhK9RvdxErnqA> <xmx:tcvNW32TV_yxNUYRhs06YUXnzYk1io21d5jbbO6kTUU-dSVyF7RQ-A> <xmx:tcvNW6UrrKMJ81CXO0WnJy256wjZ7ivjX7kOiWn86MTk-gw3xoWWbg> <xmx:tcvNW32IK5hw9pjJNR9ehIPqM51Qa9MyRvFZbiZpCeEediRn5nVENg> <xmx:tcvNW3vqcCrokLF-72Ou1tiWiJ4oSkfG3uEFe38a01Dj9IL0Go-beQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 77588102E8; Mon, 22 Oct 2018 09:08:04 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: Dan Gora <dg@adax.com>, dev@dpdk.org, Igor Ryzhov <iryzhov@nfware.com>, Stephen Hemminger <stephen@networkplumber.org> Date: Mon, 22 Oct 2018 15:08:06 +0200 Message-ID: <3348901.PjEyPxuV6a@xps> In-Reply-To: <1269b37a-cb2f-c343-18a8-f4a5993fc903@intel.com> References: <20180911232906.18352-1-dg@adax.com> <20181019002358.17132-1-dg@adax.com> <1269b37a-cb2f-c343-18a8-f4a5993fc903@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 22 Oct 2018 13:08:06 -0000 22/10/2018 15:03, Ferruh Yigit: > On 10/19/2018 1:23 AM, Dan Gora wrote: > > Hi All, > > > > Attached is version 5 of a patchset to add a new API function to > > set the link status on kernel interfaces created with the KNI kernel > > module. > > > > v5 > > ==== > > * Update Kernel NIC Interface document with new rte_kni option, move > > kernel module parameter description here from KNI sample app > > document, general cleanup. > > > > * Update Kernel NIC Interface sample application (kni) document > > with new command line parameter, remove documentation for rte_kni > > kernel module but add reference to it, general cleanup. > > > > * Change link status change sample rate for KNI example app to 500ms > > from 100ms. > > > > * Fix bug in parameter parsing in v4 in rte_kni kernel module. > > > > * Fix output formatting of optional parameters for rte_kni with > > modinfo. > > > > * Fix permissions of optional parameters for rte_kni. > > > > * Squash patch to add test for rte_kni_update_link into patch > > introducing the API function. > > > >> v4 > >> ==== > >> * Rework rte_kni_update_link to only take linkup/linkdown as parameter, > >> return previous link state, and remove log messages. > >> > >> * Update patch to set default carrier state to make default carrier > >> state configurable by passing the 'carrier=[on|off]' option to > >> the rte_kni kernel module. This is necessary in order to allow > >> applications which use KNI as pure virtual interfaces without > >> corresponding physical ethernet port to use the interfaces without > >> having to set the carrier state to 'on' via rte_kni_update_link() > >> or by writing to /sys/devices/virtual/net/<ifaceX>/carrier. > >> Note that the default is 'off'. > >> > >> * Add command line flag '-m' to examples/kni to continuously monitor > >> and update the KNI interface link status according to the link > >> status of the corresponding physical ethernet port. > >> > >> > >> v3 > >> ==== > >> * Use separate function to test rte_kni_update_link() in 'test' app. > >> > >> * Separate changes to 'test' app into separate patch to facilitate > >> possible merge with https://patches.dpdk.org/patch/44730/ > >> > >> * Remove changes to set KNI interfaces to 'up' in example/kni > >> > >> v2 > >> ==== > >> > >> * Fix bug where "Fixed" and "AutoNeg" were transposed in the link > >> status log message. > >> > >> * Add rte_kni_update_link() to rte_kni_version.map > >> > >> * Add rte_kni_update_link() tests to kni_autotest > >> > >> * Update examples/kni to continuously monitor link status and > >> update the corresponding kernel interface with > >> rte_kni_update_link(). > >> > >> * Minor improvements to examples/kni: Add log message showing how > >> to show/zero stats. Improve zeroing statistics. > >> > >> Note that checkpatches.sh compains about patch 1/5, but this appears > >> to be a bug with check-symbol-change or something. If I move the > >> fragment of the patch modifying rte_kni_version.map to the bottom of > >> the patch file, it doesn't complain any more... I just don't really > >> have time to investigate this right now. > > > > thanks > > dan > > > > > > > > Dan Gora (5): > > kni: add API to set link status on kernel interface > > kni: set default carrier state of interface > > examples/kni: monitor and update link status continually > > examples/kni: add log msgs to show and clear stats > > examples/kni: improve zeroing statistics > > Thanks for the document clean up. > > For series, > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> > > > Thomas, > > There is a possible doc update, what do you think fixing it while applying? Or > do you require a new version? What is the update to do?