From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 359F8460FD; Thu, 23 Jan 2025 17:06:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BACF44028A; Thu, 23 Jan 2025 17:06:48 +0100 (CET) Received: from fout-b8-smtp.messagingengine.com (fout-b8-smtp.messagingengine.com [202.12.124.151]) by mails.dpdk.org (Postfix) with ESMTP id 3139440261 for ; Thu, 23 Jan 2025 17:06:47 +0100 (CET) Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfout.stl.internal (Postfix) with ESMTP id 776E31140175; Thu, 23 Jan 2025 11:06:46 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Thu, 23 Jan 2025 11:06:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1737648406; x=1737734806; bh=xcbgKAH49RiL6xGo9oO5ZVsFFtJ3MQQXYLUzysZuG1I=; b= zSv8v0FkeMqss9JcagHxQ4i6QtFs2XK4KXyB2QSmWzVT7p6h6Z3QTtQyJML4stsS Mi8fen/jQIWmS+bFwq0f+ivvnPgjK0w6kWHMpLc5cJ4NRRlFItCTySGeP8SQkFaM hbSFnB8i8pjFNC6pdmzQKQf6GHdbrMTGFPl2STPYAka+ft5MOxZ8uz5R3ZeCRZ6D OQZGecHnvJrOtu5lhc7TIlds73gwqL7riGtIxCQLe0gu+WVf5w3AILGWTAWEDbj2 AcksA5Ut49777ux4fnTCvXcv8BXZxrBPfseF2vsA6EwLs4m04oqi8AvLz53aFV3t vCqm7P/xzSjWMdHy4tTGrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1737648406; x= 1737734806; bh=xcbgKAH49RiL6xGo9oO5ZVsFFtJ3MQQXYLUzysZuG1I=; b=H BWLBAzyhlOQFxQgyRko8Z+QYrlNLDcHRb2RFmA9RI23eaGm0BjxcMEdwNxZ73eNT zeyuvkS0r4u2ZnZ09o8V+IdQSBQs1kDiaWGHcnJiJ47zhPwiAcdKVpzzxNQzfcEE Y2+zKAkFqbj4vNjM8ma4J96+m9+B3JreWVWmzEonDlpPizM5LUKNCgoogiDiYJmC AToHBteAzj6ef7weyi94IzMJTxVKAWgC3WdK6JNqI4aH6uLD6D8r6q4DCBrCgQ/I xB62H4fn77987CYkl8Js5pSxhcfKjsc0ycw9VUVrrcMXWD5pxwgpGw+L4y65qYLB z5Gmknk/jmwC61juNalaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudejgedgvddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdej necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeev tdehvedtkeeivdeuuedvieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdp nhgspghrtghpthhtohepiedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepsghruh gtvgdrrhhitghhrghrughsohhnsehinhhtvghlrdgtohhmpdhrtghpthhtohepuggrvhhi ugdrmhgrrhgthhgrnhgusehrvgguhhgrthdrtghomhdprhgtphhtthhopeguvghvseguph gukhdrohhrghdprhgtphhtthhopehirghnrdhsthhokhgvshesihhnthgvlhdrtghomhdp rhgtphhtthhopehvlhgrughimhhirhdrmhgvughvvggukhhinhesihhnthgvlhdrtghomh dprhgtphhtthhopegrnhgrthholhihrdgsuhhrrghkohhvsehinhhtvghlrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Jan 2025 11:06:45 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , David Marchand Cc: dev@dpdk.org, Ian Stokes , Vladimir Medvedkin , Anatoly Burakov Subject: Re: [PATCH v5 02/25] net/intel/common: add pkt reassembly fn for intel drivers Date: Thu, 23 Jan 2025 17:06:43 +0100 Message-ID: <3349664.G96rZvMJ2N@thomas> In-Reply-To: References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20250120120016.1530274-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/01/2025 15:17, David Marchand: > On Mon, Jan 20, 2025 at 1:00=E2=80=AFPM Bruce Richardson > wrote: > > > > The code for reassembling a single, multi-mbuf packet from multiple > > buffers received from the NIC is duplicated across many drivers. Rather > > than having multiple copies of this function, we can create an > > "intel/common" directory to hold such functions and consolidate > > multiple functions down to a single one for easier maintenance. > > > > Signed-off-by: Bruce Richardson >=20 > The new drivers/net/intel/common directory is an orphan. > Please add it to MAINTAINERS. >=20 > An alternative: to avoid such miss in the future, it could be worth > having a dedicated block in MAINTAINERS for drivers/net/intel/ with > subtree set to next-net-intel and an associated subtree maintainer > name, then move all Intel drivers in this block. >=20 > Thomas, opinion? I'm not sure about creating a new level. It needs to be the last one of the parent block to make our script working. Can we start with just a new entry for the common directory?