From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id DE7588E6C for ; Wed, 4 Nov 2015 01:05:02 +0100 (CET) Received: by wmeg8 with SMTP id g8so97818930wme.0 for ; Tue, 03 Nov 2015 16:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Fuc1kyLOg8CYMIPfpAiRC2DDXBz5OvOJs+Yg1WHczNQ=; b=HwgzJUhE4LD+oDWC39nvTt/ucPtqw86JYyhB0voqABvGUBkBf2y65fJI/vMQ/dncW0 73M6tRYxDQtsfJnjm23DS0+E5REedODTrSDUCYUKMbLseRJVsFzt9Svi66wiPL7m06aa NSHOjht0bnp3hkeN5za4LrNTFpQcsLPBjiv1a8bfuCEZ18mgKwuyS6xGMp5y9gyHVyDt kn1Rtdb2F74f4xdfhZ84Ch4OFo/qEl+CsHm+nPRC7YRmNRKyQ4r1OKaHhE+W9N7Yv3d1 E61nxIxafGp0plt77b7YoTh0JBIubYc5wqt2xmLFtEBxie1bHaIbm1q357fqd78YL+96 FBSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Fuc1kyLOg8CYMIPfpAiRC2DDXBz5OvOJs+Yg1WHczNQ=; b=OMA24ZIIhX39OCUlbAqjP+QQYAb10t7bS4kjPnS9KVfIw6NlFZLr0FjEKl3EKwje/q dq1jCM7He+wFaDOS+n7XG5onoHZ54goi18AY1W4vcryp42EZY7rGQdWeUhIJIjFEQ6gK CZL5i0MeM8Su9zKxG1RYsHiQEg1DGaf8d6oFfQXdf9vN49m90tPsFtusurTz6Eis0AuK hHbuGIOa8cLcBkKzJv4xAHT/tIobbNJ3YoRIEdWuEEAlA5r0+KJxfMdtBycTQp5Ifcl8 1plCZt5NRTz/xXXGmNHYBzPum0hbthrtB/P5D420EnHwHeZOGL5mMqh042/qu9S59qVW CUCQ== X-Gm-Message-State: ALoCoQmRRh0KaaUfrRuLdl1KoXakrsX2dOojYeNgSHxRGglIKITB8P5QqKiWWKoCs0ryCjujsr6d X-Received: by 10.28.22.203 with SMTP id 194mr20604392wmw.45.1446595502796; Tue, 03 Nov 2015 16:05:02 -0800 (PST) Received: from xps13.localnet ([93.158.41.25]) by smtp.gmail.com with ESMTPSA id jq10sm23311898wjc.37.2015.11.03.16.05.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Nov 2015 16:05:02 -0800 (PST) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Date: Wed, 04 Nov 2015 01:03:24 +0100 Message-ID: <3350203.vEc0KsLCbN@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B03596598C@IRSMSX103.ger.corp.intel.com> References: <1446207772-58543-1-git-send-email-pablo.de.lara.guarch@intel.com> <1446215848-122581-1-git-send-email-pablo.de.lara.guarch@intel.com> <59AF69C657FD0841A61C55336867B5B03596598C@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] hash: fix scaling by reducing contention X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 00:05:03 -0000 > > If using multiple cores on a system with hardware transactional memory > > support, thread scaling does not work, as there was a single point in the > > hash library which is a bottleneck for all threads, which is the > > "free_slots" ring, which stores all the indices of the free slots in the > > table. > > > > This patch fixes the problem, by creating a local cache per logical core, > > which stores locally indices of free slots, so most times, writer threads > > will not interfere each other. > > > > Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") > > > > Signed-off-by: Pablo de Lara > > Acked-by: Bruce Richardson Applied, thanks