[dpdk-dev] [PATCH] doc: announce kernel driver enum removal

[dpdk-dev] [PATCH] doc: announce kernel driver enum removal

[David Marchand]

rte_kernel_driver is only used by the PCI subsystem and has polluted
ethdev for no reason.
Hide it in the PCI bus driver.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9f73297173..6e86963c39 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -81,6 +81,13 @@ Deprecation Notices
   With this removal, there won't be a need for the mentioned workaround which
   will be reverted.
 
+* pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private
+  to the PCI subsystem as it is used only by the PCI bus driver and PCI
+  drivers.
+  The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure
+  will be removed as it gave no useful abstracted information to the
+  applications and had no user (neither internal nor external).
+
 * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
   will be done in 20.11.
   Currently the ``struct eth_dev_ops`` struct is accessible by the application
-- 
2.23.0

Re: [dpdk-dev] [PATCH] doc: announce kernel driver enum removal

[Bruce Richardson]

On Tue, Aug 04, 2020 at 04:07:52PM +0200, David Marchand wrote:
> rte_kernel_driver is only used by the PCI subsystem and has polluted
> ethdev for no reason.
> Hide it in the PCI bus driver.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 9f73297173..6e86963c39 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -81,6 +81,13 @@ Deprecation Notices
>    With this removal, there won't be a need for the mentioned workaround which
>    will be reverted.
>  
> +* pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private
> +  to the PCI subsystem as it is used only by the PCI bus driver and PCI
> +  drivers.
> +  The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure
> +  will be removed as it gave no useful abstracted information to the
> +  applications and had no user (neither internal nor external).
> +
>  * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
>    will be done in 20.11.
>    Currently the ``struct eth_dev_ops`` struct is accessible by the application
> -- 

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH] doc: announce kernel driver enum removal

[Gaëtan Rivet]

On 04/08/20 15:29 +0100, Bruce Richardson wrote:
> On Tue, Aug 04, 2020 at 04:07:52PM +0200, David Marchand wrote:
> > rte_kernel_driver is only used by the PCI subsystem and has polluted
> > ethdev for no reason.
> > Hide it in the PCI bus driver.
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index 9f73297173..6e86963c39 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -81,6 +81,13 @@ Deprecation Notices
> >    With this removal, there won't be a need for the mentioned workaround which
> >    will be reverted.
> >  
> > +* pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private
> > +  to the PCI subsystem as it is used only by the PCI bus driver and PCI
> > +  drivers.
> > +  The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure
> > +  will be removed as it gave no useful abstracted information to the
> > +  applications and had no user (neither internal nor external).
> > +
> >  * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
> >    will be done in 20.11.
> >    Currently the ``struct eth_dev_ops`` struct is accessible by the application
> > -- 
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Gaetan Rivet <grive@u256.net>

-- 
Gaëtan

Re: [dpdk-dev] [PATCH] doc: announce kernel driver enum removal

[Thomas Monjalon]

04/08/2020 16:44, Gaëtan Rivet:
> On 04/08/20 15:29 +0100, Bruce Richardson wrote:
> > On Tue, Aug 04, 2020 at 04:07:52PM +0200, David Marchand wrote:
> > > rte_kernel_driver is only used by the PCI subsystem and has polluted
> > > ethdev for no reason.
> > > Hide it in the PCI bus driver.
> > > 
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > +* pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private
> > > +  to the PCI subsystem as it is used only by the PCI bus driver and PCI
> > > +  drivers.
> > > +  The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure
> > > +  will be removed as it gave no useful abstracted information to the
> > > +  applications and had no user (neither internal nor external).
> > 
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Gaetan Rivet <grive@u256.net>
Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks