From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B621025B3 for ; Sun, 14 Jan 2018 23:50:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 42A3D20D54; Sun, 14 Jan 2018 17:50:44 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 14 Jan 2018 17:50:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=aMz52PiKNknO5bSOxiBjXUWf1J uEbpuSAc5vvibjdlQ=; b=WHR7sw68VTaJuT9H9gKJLUHzZb4k4ankMtu5mg3vPr WUASKUAhn9k3d+lgbFQRmpiWZWBzfIajryqUFAhNo0IWtxHo/sxyc3AIwuQ8YQCA kqvR/k7qX4Olkf9I9xuETd5S19xoPZit2dLMYraMdmjtIVaKnflAcZ28BwVM9nEi A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=aMz52P iKNknO5bSOxiBjXUWf1JuEbpuSAc5vvibjdlQ=; b=gGk45XrE1f7OwhtGntHZXF 1BDrBH8/Op4+wa55EXBbBbiOUqLUh6Ul2j5hNwG1E4uYCpIWHFJ9e+EujFSgT1g3 L5cTQSCSu6o9bz7TDr16tT49ZRMWGvPGnctTQoLvPNXZ9tAS/4GbnVfgU9/i9aut GlGo4Vz3blCUwpZQ2I+BQw4wRmnMRsl0W6tADM3VXFkVrDZwlh6d2ozby4lPXCgV 5i+8Ou8ONPyxTRUxkecJKc9IO5L2C2krvaXDPy9FibE9qrYg5m84EIP6Z9jy5/Ja wSkZ8XcbJgOOUUJsjsT/NQRO/MpfksXgee7T9Bp9TNTiyXrAp7QIP6EteP4LxIKQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5CD824599; Sun, 14 Jan 2018 17:50:43 -0500 (EST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com, rosen.xu@intel.com Date: Sun, 14 Jan 2018 23:50:12 +0100 Message-ID: <3353485.Yvo7Hz8i5N@xps> In-Reply-To: <20180102125749.2379-2-shreyansh.jain@nxp.com> References: <20180102125749.2379-1-shreyansh.jain@nxp.com> <20180102125749.2379-2-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/5] rawdev: introduce raw device library support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2018 22:50:44 -0000 02/01/2018 13:57, Shreyansh Jain: > --- /dev/null > +++ b/lib/librte_rawdev/rte_rawdev_version.map > @@ -0,0 +1,33 @@ > +EXPERIMENTAL { > + global: > + > + rte_rawdev_close; > + rte_rawdev_configure; > + rte_rawdev_count; > + rte_rawdev_dequeue_buffers; > + rte_rawdev_enqueue_buffers; > + rte_rawdev_firmware_load; > + rte_rawdev_firmware_status_get; > + rte_rawdev_firmware_unload; > + rte_rawdev_firmware_version_get; > + rte_rawdev_get_attr; > + rte_rawdev_get_dev_id; > + rte_rawdev_info_get; > + rte_rawdev_pmd_allocate; > + rte_rawdev_pmd_release; > + rte_rawdev_queue_conf_get; > + rte_rawdev_queue_setup; > + rte_rawdev_queue_release; > + rte_rawdev_reset; > + rte_rawdev_set_attr; > + rte_rawdev_socket_id; > + rte_rawdev_start; > + rte_rawdev_stop; > + rte_rawdev_xstats_by_name_get; > + rte_rawdev_xstats_get; > + rte_rawdev_xstats_names_get; > + rte_rawdev_xstats_reset; > + rte_rawdevs; > + > + local: *; > +}; It may be more pleasant to review, and more convenient to reference in the git history later, if it is a bit split in patches. If possible, I would suggest to split dequeue/enqueue, firmware and stats in 3 separate patches after the basic skeleton.