From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id F38556A73 for ; Tue, 4 Oct 2016 10:16:00 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id f193so22735208wmg.0 for ; Tue, 04 Oct 2016 01:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=qqC4hbdUIAzp6udvalnf9gjxuyYLkgNGGCp362d+qco=; b=dubcCODY2Ggr9jMGQ1jEyqoyjlB7fUwtHNfwJMqlKRXe46EfJrWspji/kgW/sRBTmB Myn7Z9lcvLdm5TKIzp/1IvQqaLfPL6504+PDq+RSmltNgpXpgVo+GX8exqEVfIAsU0yV yemYJ2BPhrkNn4a00yYQRf7gMVw9ldk8dqcSEF8808GFFHzkfVyLa9kSrw158kRQWS37 CBw/2myg8gZ44gKgfqRg0ja37ZYxhA6vv3xbk5Lgmll4uxk5uC1TEP/w4QP3uGzp8tKd oc8lJG8FPE6nAdLX7ijS9TwI7G0TUTTGeKVqS9OlPIH30yZgkyCQYKtRxW6ibzJqvFrm Bvzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=qqC4hbdUIAzp6udvalnf9gjxuyYLkgNGGCp362d+qco=; b=ZtRn1qFax/zXO0fc1o7FGzD71HAv/tjjhMtNeHhQ46faFg3qC81VxH5baRpTwVaG0d m9C9Xo8W2eUL/Tcic5qWppIlZLS4jFLsLEO7UWm8AggHAkfSOdHLxbM36yFUA2VKtq5S 8Ca6bw/2bNLf/3+sd5NlefTnMu7dW43wbC7A6lm61V8Owg0FeR9xN/sQ+hjXIYnx3JDX yX1sKDCqItW2eUHvBqydUQQ3V86/lfM0k9DCJk0RiZknYLOEQzEvqhJZl1Fo4mDX8UOV kYGdcseMwPbXnqZvsub9gHr3SBCxh4pq04x6F+E6XShELM0aumcJto0vZhKACgcgKO5X QH2A== X-Gm-Message-State: AA6/9RkvHXv69RLHJ6P9O9J2MRBpIy7c2CLBs67we3WLL0dTylk8E60DSR6Uf8hfv86gFH4K X-Received: by 10.194.201.36 with SMTP id jx4mr1816190wjc.38.1475568960744; Tue, 04 Oct 2016 01:16:00 -0700 (PDT) Received: from xps13.localnet (172.17.90.92.rev.sfr.net. [92.90.17.172]) by smtp.gmail.com with ESMTPSA id y2sm2151756wji.42.2016.10.04.01.15.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2016 01:16:00 -0700 (PDT) From: Thomas Monjalon To: Sinan Kaya Cc: dev@dpdk.org, Stephen Hemminger Date: Tue, 04 Oct 2016 10:15:56 +0200 Message-ID: <3354300.QnNDgIpU56@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1469201650-32447-1-git-send-email-okaya@codeaurora.org> <20160722141259.35ea0a7e@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: support PCI domains X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 08:16:01 -0000 2016-07-22 18:56, Sinan Kaya: > On 7/22/2016 5:12 PM, Stephen Hemminger wrote: > > On Fri, 22 Jul 2016 11:34:10 -0400 > > Sinan Kaya wrote: > > > >> The current code is enumerating devices based on bus, device and function > >> pairs. This does not work well for architectures with multiple PCI > >> segments/domains. Multiple PCI devices will have the same BDF value but > >> different segment numbers (01:01:01.0 and 02:01:01.0) for instance. > >> > >> Adding segment numbers to device naming so that we can uniquely identify > >> devices. > >> > >> Signed-off-by: Sinan Kaya > > > > I ran into this yes. There is a small risk of breaking some application that > > assumed something about names though. > > > > Acked-by: Stephen Hemminger > > > > Thanks, hopefully the change is minor and can be contained until next release. It is part of the EAL rework. The function has been moved in EAL and includes the PCI domain: http://dpdk.org/commit/affe1cdc