From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4546FA034C; Sat, 26 Feb 2022 16:57:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA256410E9; Sat, 26 Feb 2022 16:57:55 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id CB8064068F; Sat, 26 Feb 2022 16:57:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645891074; x=1677427074; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=CbsEAelGhgxdJAjFtLj+i+q576xqsBf/nE75Vu6zosA=; b=li24vBGxFtad+KyEci7pFfLsCK2pa2tcHoSfI2DA6h87pv7CNKD/gAHW BRl50Y0fQJT35TFT4KAs4Lxnhh2y9xpLal0Fs0nRS1mg8PooKtMPVJoeo JegtSLlYdXlN3YO0ifjSbAOUUbi5x/ujZUDo/Q4U2DITl17j8HeADdMv0 1OEvEIrJeZOP/SyCMH9jB8jW86DbLMB03oI3QpdrpA0LwbsPK9nzqj7rM CfezT09gEdW744QxgZ/g9OsuROdgIF/gCg3cXss91DdsWyQ9REvCR4MT8 WL6ZD0YXaFC04YzXwQfti+Q+5LrvPuq4YtjYGB8wTH/G7cgenyos5VbZj g==; X-IronPort-AV: E=McAfee;i="6200,9189,10269"; a="250248174" X-IronPort-AV: E=Sophos;i="5.90,139,1643702400"; d="scan'208";a="250248174" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2022 07:57:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,139,1643702400"; d="scan'208";a="506992483" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 26 Feb 2022 07:57:52 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 26 Feb 2022 07:57:52 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Sat, 26 Feb 2022 07:57:52 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sat, 26 Feb 2022 07:57:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WOggZIPeVcFnYaBkl8Qr9SMMYyjbEB5mzDoeQJ+IYycMZPy30CZw2DbKA5522rtry8GkhPS+HSsRlPcJ2Wy2xYZSGZ5brrVyNNXoKd87rX4PrDcX6Zjw1EN2ktAWcUGuc+5qW+6M7f0+6JCleseg2NQ8lwbf0zOQ7T/P/2LFv1uc7TuyVC9y+WmMgaF4fTlHLKHaquZ7jFl9xveRf0/napgeMYfUf5erjo6OPtXtxUJbTTN1y2Oze3pc3GF5e55L4jQn1rYKJV7EHRSYoAreu/hgaqqcTiixJWuQiVxD5XHsg3ph85Oe6NFMwdW7hrerNMrikAWpFMFZzs6LFX+z3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NO+XAzH7Qqk5J8ZArfH35aPGr7SGHSYsdYssxOFJD+g=; b=YeKq8oh+qBM6Temd5jzSn30cCDO1dcjgbqEkCXpA5ZCSwVsiFmN/J9JSTKrFpuE6+6ePNQ1IJI1td2YI19EYwQWcK4tEkjtLfLOFYL4FyFrYauottlpuVepRYWFo5oDBuGFkn6jVLOKOSDBRGntJsye7xGLFai+EL38HZYl8PGtvKet589hCv/uYBMlzzMZ4KNWpbhkqejU9v2QvHdJnyLxy8IDStbVe4Ky/hqKEgYZSSkbzazY2ApS8VGrUDJ3a6OIOAOIYWHpM1cHx43EGvcuZNbdBjSYCR1aB4yRR3TeutdRynUbi5iKJHPMEYGSIT4XkyJ4Zmj+wPDAtbdJadg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CO1PR11MB5123.namprd11.prod.outlook.com (2603:10b6:303:94::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Sat, 26 Feb 2022 15:57:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%5]) with mapi id 15.20.5017.026; Sat, 26 Feb 2022 15:57:48 +0000 Message-ID: <33574d33-7b58-89f7-4021-f1e5f7e05123@intel.com> Date: Sat, 26 Feb 2022 15:57:42 +0000 Content-Language: en-US To: Jeff Daly , CC: , Stephen Douthit , Haiyue Wang References: <20211206221922.644187-1-stephend@silicom-usa.com> <20220225205025.19575-1-jeffd@silicom-usa.com> From: Ferruh Yigit Subject: Re: [PATCH v4 3/3] net/ixgbe: Fix SFP detection and linking on hotplug X-User: ferruhy In-Reply-To: <20220225205025.19575-1-jeffd@silicom-usa.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0494.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32df468d-ceb6-4bd7-979e-08d9f940bc5d X-MS-TrafficTypeDiagnostic: CO1PR11MB5123:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m+ecLucqh+ccVrD5BAttAimI2M9U2u+G2G6d9HBwgnsNCW6ojNcWP09rkIx27XuJNj1IJZ+thf0duO4AYd7ThAOPRPcZ+orbK/TVnqVGMILxxHCMVx8TQLzemxaGsTW1EYc6yrQGSfWvGJtMu04RXkQgvbzG+IPySJzzCUNebqa7/yGtEmvHoqUeR/sd4MFgkWtS5ZerE/bR1+izP9co6J9FYXFht7FpmgAGpArlATXUcnh4gDi4Z/APDOiUij1ppULVf37OWgpPnanlD1zwn+Zscg57pIkrV2gE3e5eovZgGb7S3rAiWn2YsnW//23Dj1/g7A/jvCRFSPdylIbpCmDtOe9zHW2nt/qma4bjU+ZqdtK5FwsRKTohjDF+fn85btszLfT9zKHTjQFzWky5ovU6si2pe5Ju4fzSifwEoEITdcpWjrl0vePgcLyFlvy1k+hj0tLVqtAf+Pc64J5mDd1EK2gE3v9QIrCgteYUplRhjjosRahevRy3CseuwgmXLhjp5nfJ35xPos50NN3b7/1hnyrbCrWEIUmq9GKFcm+pkW6RzkDivGdVebJw7OcYiJitCcWAUm1tn5BKppNb852I8lqlFisMNvFJIC9V3pMZgJqXc87UGeV32sORW2d6tTk7JNxMmJPengW6aR+GKr+TTEODcs/uQ8Fmdgwj7R9lawFMUZGVWljeqj2c0HfnBHR4KFDaZw+Wz/l5ZZ9EMA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(5660300002)(83380400001)(44832011)(186003)(2616005)(8676002)(66946007)(4326008)(66476007)(8936002)(316002)(54906003)(66556008)(31686004)(86362001)(38100700002)(82960400001)(36756003)(2906002)(6486002)(107886003)(6506007)(508600001)(6666004)(6512007)(53546011)(31696002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEs3RkV6NDVNS3R3c0JDSENZWmJiNHZ5bnhwR3Q5QkJxMVNpclExc0R5dXUx?= =?utf-8?B?SzlhZ1pReXNlV3JrNDBLRVRENXZnckQvTWhVYmxqcmtESDY0Qm1Oa3VTdG5G?= =?utf-8?B?TGpsMHdoU1l4Y3pkTmNJNlhpTmFVZmQ1YUJ3TittY3AwUHlWYkUrTU1DTmNF?= =?utf-8?B?MnkzQlArRUxLM3JIanpTcklwT1ArR0NMR2ZGY0JicWlnT0ZjV1UyNzlNd0tC?= =?utf-8?B?cHhLdFZoL0l6UVUyL3FETjVKVWZ6SmlOMkpBRFJsSmNVaFE4V2RoQjVFcnc3?= =?utf-8?B?QUNnNTdiUVVxMER5MThHTlREM250MmxtUHV3TFdUKzFsK2lqSFhFd3d1V2VY?= =?utf-8?B?cXRuVmZNWUZYd3FuQVo4MEdrb1RTODFJTkw5bkNORWxSMktIZlBIUGZYNEN5?= =?utf-8?B?QlpqdVRZc0F2UzliZGtDS3hOL2FXYTh5dzZteG9FcytPRHFRd1NKSUcyampn?= =?utf-8?B?elZCcU9ocTJ1ellISk4wSzRjMTR1YVk4VENVc1FSUHZXUzZXOE5VV3RwNGZQ?= =?utf-8?B?U1MyMjVMQ2V5Qk5wM0RsZUhseDNIQ3pPVXY0ODBscnRPVVh6SGNOTGlSeXhW?= =?utf-8?B?TXIxU00vb2tLMWQvaFgzOFU5cmt2SE9NZis4UUFXVUNiSkt4V0ZnbXE1WDh2?= =?utf-8?B?QXlSUGlMdlJIWTJlU3NrMDJUOHFWNm5qNThWdWRPSjBXOHVYWEs0Rm5YWVE0?= =?utf-8?B?YnRWNy9zNUlQYUE4bmNvZnduelhtYnBEOVR6T3dBcHBnbEZLZzc3S0wwK1lM?= =?utf-8?B?QW53emFkTjNDNFNjM0kwLzVKNDVYTlNpMkRsTWlYd0Z1MTZGSFc1YUxzQW44?= =?utf-8?B?aUY1RmNNRDRUd0I0cnRsL1NKMlRXdUZibXV2dmVFTTNCVk1qd0NLemQ5Z3U2?= =?utf-8?B?QUlEaGdka1A0N2pZamZaSTBLUC9UODRDSVk2ZWdIcXBOQ2RHRUVNNjA3a01a?= =?utf-8?B?T2w5UEZaWm8vN3VrZ2lyd2h4TGdBOEh4N2pkeVNpL2lUbnV6K05aeHN5ZlBQ?= =?utf-8?B?ZjJ4L2lXajVRZjJLNStpM0ZQT3ArTi9pZG1wc2oxZzZWdFpQVnZtc2MwVDV2?= =?utf-8?B?L1dmTEpXUHpFYWJRajlYL1FXVDgzR2NXSFdNamhzVXJhaVpFYVQ4V1JZZmYy?= =?utf-8?B?MGpNRlN4TVR3WjErSE9lQnZmdkxwWkE0aWVPR1V6cmlqenFGOVFSZGQrNWN4?= =?utf-8?B?ODNHamVTMU9kNWd2N3BGcTJlOTdsd1VWS1EyYnAzSGtkMzdwZTUwYkRZblM3?= =?utf-8?B?WUhTWlR5czNaK0h4WmxnZmp1RVN2VkdPSkVLamxBWWxVQy9KdnByWGtMTm80?= =?utf-8?B?YXFYYkpIU2NFbFloTVVhSGFEdG9CMi84NkhsRStVR3UvQURKM1VCSkRHV0Mx?= =?utf-8?B?QXAxN2xkTlBDTThvNGxSWGRJR0RwN0gxc1Q0amM5QUJUN0w5Z1FzVk5BcnFV?= =?utf-8?B?M3g2WDBDbG5LQTNlVkRkellNWU1TeE9iaWxmOE0vQ01Ba3RXTHFuZkdPb21T?= =?utf-8?B?VHZlTEtNcGZhT1d5empnS0FGTHRvaTU4NllEZUo5ZW1KRlFhL1Rhdy8zRlJG?= =?utf-8?B?OTQ1VmhZVERCZTVNdm1aZStJajBmVTA4WnRvZk5LTDAzSkpYcURGdk5ZQ0ow?= =?utf-8?B?K2VKYk9LRGtTdzEvZXl6Q2didTV5d0pXemxnUUR6T0JueEdjRzVmU2hsZ1k5?= =?utf-8?B?MzhEN1JTNGdRRi9QeUZhWUoyNnBpbWtDZkxteHNQMFZJd3IxTytsZlBYT2JV?= =?utf-8?B?SFFLRUxzQ3BNZ0VjaW55NWpuTkVTZ1UrTmhDZnVtK01PVnExVnRYcGFFejM5?= =?utf-8?B?azFqUE4rNHdWdmVTV0RRYmtGS2lFcEJZU0U2TUsvRVg4VUJrNWRIU2FRTmMw?= =?utf-8?B?MDl3QlNNVjhWZmk3TDNLbWFUOFRjTmFmQ05hQVRkV1FGSVdEVmJnVlZVdVJH?= =?utf-8?B?VmdIQVY4U09sYTdPYlVOdkFzUmp0S0ZYN0t6ejVpNGhVYVNEdnFLY1dsMHY2?= =?utf-8?B?WGdYVlRYRUJHQndhLzV4TUk1OWFoaGxZV2dYOUFiYkxtNEorMlRoazkzV0lz?= =?utf-8?B?S0MzVWdkR1ZUV3Nza3ZJclJ3ODA5N2QreGk1YU1lZEtRbmkydlBxdXp0RlZy?= =?utf-8?B?aFZtYVJ2bVpvNHNjWlc2bW14WU9PUkxoL1g5VDhwaFpDTEJ3RmVwMFFJbEkr?= =?utf-8?Q?gMLwu94d+03FJjrolq7EDZY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 32df468d-ceb6-4bd7-979e-08d9f940bc5d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2022 15:57:48.6390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rx/xE2i4aMrT2jXfeYxfBIJj0+zaUDeVbuCSOBFE9CF8/zqYKZm3J2R802qUVxzRKnvnkbMMNZsTMvdA14RYWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5123 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/25/2022 8:50 PM, Jeff Daly wrote: > Currently the ixgbe driver does not ID any SFP except for the first one > plugged in. This can lead to no-link, or incorrect speed conditions. > > For example: > > * If link is initially established with a 1G SFP, and later a 1G/10G > multispeed part is later installed, then the MAC link setup functions are > never called to change from 1000BASE-X to 10GBASE-R mode, and the link > stays running at the slower rate. > > * If link is initially established with a 1G SFP, and later a 10G only > module is later installed, no link is established, since we are still > trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner. > > Refactor the SFP ID/setup, and link setup code, to more closely match the > flow of the mainline kernel driver which does not have these issues. In > that driver a service task runs periodically to handle these operations > based on bit flags that have been set (usually via interrupt or userspace > request), and then get cleared once the requested subtask has been > completed. > > Fixes: af75078fece ("first public release") > Cc:stable@dpdk.org > > Signed-off-by: Stephen Douthit > Signed-off-by: Jeff Daly Hi Jeff, Can you please send new version of whole set, instead of only one of the patches? It is very hard to manage different versions of individual patches in a set.