From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CE8DA0C43; Fri, 26 Nov 2021 14:23:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6337D42751; Fri, 26 Nov 2021 14:23:41 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 73F18406FF for <dev@dpdk.org>; Fri, 26 Nov 2021 14:23:40 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1E8115C008C; Fri, 26 Nov 2021 08:23:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 26 Nov 2021 08:23:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 6+HuvhNHFa7abyqJrREaaBg+C+W7OIo7BgAJC2SN3Q8=; b=ZTDiR8GgU+2tP33M XP88grEi5EAmx0rcPeHToLYP0d1Yfl7+Uj5Z9nfnjKMK2vGBvbzFqghsQa/B9yJX RWBBCXx+zOCbDbmpLt7n9RJz1Y3SdKdDC+zGxhCOMiBAc/IUKTbPn6KqB/tKiWrM YcIVzOiQa7pXBGaqeQQFUuZbu4WVyn4mgyxWqAQ6UWrrk3VnlvYzDt72Ccba+XXz MV/W0rDuTYaHhmEwrwsNEfcT+ysksRR31nDu0JmsY6ZtQv/UVV1GW9UUlWNg+2Jq AtTjsWOAgSZu0vKt/MShdV1NTx0kYUh71jD6gTBpzLgrz0+UV2ddyj1ZH/LOk1wq scy7kA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=6+HuvhNHFa7abyqJrREaaBg+C+W7OIo7BgAJC2SN3 Q8=; b=X0Suv8uDJOaJ6NPTDteChln2queXsaH7Q33dr7TOhl6VgNaSxOxWt43a+ s5DJWNiPb06A5yhFULilMnWNXjgs5jsLd/C3kovXCF/0+KrTs4aG3kWhz5PN4Cj4 6pDpY5wntMAT8TWbJN6VHbxX46EuTdnOru6TU2yTl3SkqIM3sJh/uITTx1xzt3dI l+vh2W7CMsVxRCZes4sF8XxOOUEN38462beTtDyBjambE8x7dBpl8JNiMCqHB+kI HUcZF+xiRuEYth8l3V8J1WIwH2v/NWL2wV9nVGiEgaQUQXXdsMyMRLYvH6KLlW7n NcCr0HBHfeB4A2pvC8iFGZPS3Xx8A== X-ME-Sender: <xms:29-gYV-ZM3GW2ElXRqQLovC3hzfBafuouMa--hAu1XW5rpOD2uKM0Q> <xme:29-gYZvDTZynj6ZJdLRo2J4GwDHBdaC9roM7zPGAxJ5TdNJ6WEIONzn54Eib0jrpC Tx_Z3kAb4me4o3kGA> X-ME-Received: <xmr:29-gYTDjHR__QrSCaYLJixdLMhdIEjCdgWw371SoTTApW3ggeJX9NTSSBMLy0gAVLK29psu_9AqAogtvWqE9Vv9C5g> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedvgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:29-gYZdH-m56vzCxM3EoX4GYhFiRbqokV4FcmxaGIFVtVmAgXqYGug> <xmx:29-gYaPpWUo3bwmIwR4IzoEO0QpXVjWdbQb4DAFKLJe5GiGJH0ckYQ> <xmx:29-gYbmIW60Xb6FuOxRgYqoCyDYzhYaRP3_zLw9u1loLBgaogV6JVw> <xmx:3N-gYXrsHMJZUFCbzVjab7n7LjnZheDW51C4-FWS8wlwkmqhr7jPaw> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Nov 2021 08:23:39 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: David Hunt <david.hunt@intel.com> Cc: dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, david.marchand@redhat.com Subject: Re: [PATCH] doc/power: add info on scale mode reaction time Date: Fri, 26 Nov 2021 14:23:35 +0100 Message-ID: <3358423.LUpCnhhR32@thomas> In-Reply-To: <20211124165300.31165-1-david.hunt@intel.com> References: <20211124165300.31165-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 24/11/2021 17:53, David Hunt: > When using PMD Power Management, scale mode reacts slower than > monitor mode and pause mode. Add note in user guide to this > effect. > > Signed-off-by: David Hunt <david.hunt@intel.com> > --- > This power saving scheme will use ``librte_power`` library functionality to > - scale the core frequency up/down depending on traffic volume. > + scale the core frequency up/down depending on traffic volume. The reaction > + time of the frequency scaling mode is longer than the pause and monitor > + mode. [...] > - This will use frequency scaling routines > - available in the ``librte_power`` library. > + This will use frequency scaling routines available in > + the ``librte_power`` library. The reaction time of the > + scale mode is longer than the pause and monitor mode. You don't have to change existing lines to add a new sentence. That's why I recommend always starting a new sentence on a new line. I fixed it to make the patch cleaner. Applied