* [dpdk-dev] [PATCH] pci: fix one device probing
@ 2016-08-04 11:50 Igor Ryzhov
2016-09-16 13:20 ` Thomas Monjalon
2016-11-07 13:26 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Igor Ryzhov @ 2016-08-04 11:50 UTC (permalink / raw)
To: dev
The rte_eal_pci_probe_one function could return false positive result if
no driver is found for the device.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---
lib/librte_eal/common/eal_common_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 7248c38..bfb6fd2 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)
continue;
ret = pci_probe_all_drivers(dev);
- if (ret < 0)
+ if (ret)
goto err_return;
return 0;
}
--
2.6.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] pci: fix one device probing
2016-08-04 11:50 [dpdk-dev] [PATCH] pci: fix one device probing Igor Ryzhov
@ 2016-09-16 13:20 ` Thomas Monjalon
2016-11-07 13:26 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-09-16 13:20 UTC (permalink / raw)
To: Igor Ryzhov; +Cc: dev
2016-08-04 14:50, Igor Ryzhov:
> The rte_eal_pci_probe_one function could return false positive result if
> no driver is found for the device.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
[...]
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)
> continue;
>
> ret = pci_probe_all_drivers(dev);
> - if (ret < 0)
> + if (ret)
> goto err_return;
> return 0;
> }
This patch was discussed in another thread:
http://dpdk.org/ml/archives/dev/2016-August/045127.html
Is there anyone thinking this patch is not a step forward?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] pci: fix one device probing
2016-08-04 11:50 [dpdk-dev] [PATCH] pci: fix one device probing Igor Ryzhov
2016-09-16 13:20 ` Thomas Monjalon
@ 2016-11-07 13:26 ` David Marchand
2016-11-07 13:49 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2016-11-07 13:26 UTC (permalink / raw)
To: Igor Ryzhov; +Cc: dev
On Thu, Aug 4, 2016 at 1:50 PM, Igor Ryzhov <iryzhov@nfware.com> wrote:
> The rte_eal_pci_probe_one function could return false positive result if
> no driver is found for the device.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> ---
> lib/librte_eal/common/eal_common_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 7248c38..bfb6fd2 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)
> continue;
>
> ret = pci_probe_all_drivers(dev);
> - if (ret < 0)
> + if (ret)
> goto err_return;
> return 0;
> }
Acked-by: David Marchand <david.marchand@6wind.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] pci: fix one device probing
2016-11-07 13:26 ` David Marchand
@ 2016-11-07 13:49 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-11-07 13:49 UTC (permalink / raw)
To: Igor Ryzhov; +Cc: dev, David Marchand
2016-11-07 14:26, David Marchand:
> On Thu, Aug 4, 2016 at 1:50 PM, Igor Ryzhov <iryzhov@nfware.com> wrote:
> > The rte_eal_pci_probe_one function could return false positive result if
> > no driver is found for the device.
> >
> > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
>
> Acked-by: David Marchand <david.marchand@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-07 13:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-04 11:50 [dpdk-dev] [PATCH] pci: fix one device probing Igor Ryzhov
2016-09-16 13:20 ` Thomas Monjalon
2016-11-07 13:26 ` David Marchand
2016-11-07 13:49 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).