From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BE2242C2E for ; Mon, 15 Jan 2018 12:30:20 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1926B205FD; Mon, 15 Jan 2018 06:30:20 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 15 Jan 2018 06:30:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=7Ebnz0FZStedy4/6vfB8aCLHM9 sKYZKQO9eGm2UqajQ=; b=ehj1GgOqfiX3yEk2yOc0dVvybrSs8VAAqjg5tj95R6 jYOsrIDB9tr1gvkes02MJT2Lk99KEEg733N+qbt9Jkp5P0p0uvooPvMB4aRGWRgf wwuzBJv6xnTATu0xMnjC5kalSUeVgpF1wiTbMYrzlVs0UYr3EU5FI+COUtTxMUB8 Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7Ebnz0 FZStedy4/6vfB8aCLHM9sKYZKQO9eGm2UqajQ=; b=dt0ajZQ32C0y7agK0ZgF4b LU4ThPfVRQZwv1Kc03lD5VDbJ2+ORlqFeiBp3WAeLKFa72wwb98CUfMbCdbQjtJ8 gIenvzrVFABLgN58L20EQpqHKsQb3awh2mGv41c82H+i4v1+GYzLyPAvxmbUwDT4 JXIAhPGHkgNjcSYyT1FqmTJmrJucmRIQhrYApYWVse/tdyqgsVoMbCKHjOos+t1m L+nt+fcGjNyqnOgdSc6H5x6WaWZpNLl6A9F6LFrO1WOMuef8/li3YEyMwNZGnQiT Gy44JYnBrUhmvmC8RHJZA6UGF8+WtqHbVLiXJ1p6u/IkEuG0IOWYaOGhTou9K+5A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B38F224235; Mon, 15 Jan 2018 06:30:19 -0500 (EST) From: Thomas Monjalon To: "Guo, Jia" Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com, konstantin.ananyev@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, jingjing.wu@intel.com, helin.zhang@intel.com, motih@mellanox.com Date: Mon, 15 Jan 2018 12:29:48 +0100 Message-ID: <3360990.PGMcgsB7sd@xps> In-Reply-To: References: <1515575544-2141-3-git-send-email-jia.guo@intel.com> <5621685.YHClJoWfgs@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V10 2/2] eal: add uevent pass and process function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 11:30:20 -0000 15/01/2018 11:52, Guo, Jia: > On 1/15/2018 7:24 AM, Thomas Monjalon wrote: > > 11/01/2018 15:05, Jeff Guo: > >> +enum rte_dev_subsystem { > >> + RTE_DEV_SUBSYSTEM_UIO, > >> + RTE_DEV_SUBSYSTEM_VFIO, > >> + RTE_DEV_SUBSYSTEM_PCI, > >> + RTE_DEV_SUBSYSTEM_MAX > >> +}; > > > > I don't think PCI and UIO/VFIO should be described at the same level. > > Can you re-use the enum rte_kernel_driver? > > rte_kernel_driver might be not qualify for that use, since that is the event sumsystem, it include pci/uio/vfio, such strings to identify each subsystem. i will modify it to be rte_dev_event_subsystem. I don't understand this classification. A device can be both PCI and VFIO.