From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Ophir Munk <ophirmu@mellanox.com>,
Olga Shern <olgas@mellanox.com>,
Pascal Mazon <pascal.mazon@6wind.com>
Subject: Re: [dpdk-dev] [RFC 2/2] net/tap: add eBPF instructions
Date: Thu, 30 Nov 2017 18:05:22 +0100 [thread overview]
Message-ID: <33612859.oYs3VmdAvV@xps> (raw)
In-Reply-To: <20171130085408.0c7d68c2@xeon-e3>
30/11/2017 17:54, Stephen Hemminger:
> Loading BPF is a could solution to doing dynamic flow matching.
> It needs to be done differently to be accepted.
>
> Putting raw machine instructions in source code is as bad as binary
> blobs. You need to provide original source of program and then have
> build instructions to create any needed code.
The source program is provided in this patch: tap_bpf_program.c
It is pre-compiled to avoid requiring too many dependencies when building DPDK.
> There licensing concerns here as well. Any BPF program inserted
> in the kernel must be GPL. So you need to provide source.
>
> Given the license overlap you should also document that in the rte_flow_tap.rst
> file.
>
> The program that loads the program can be BSD, it just needs to pick
> up the BPF firmware file from a compiled ELF image.
The program that loads BPF is the TAP PMD itself.
next prev parent reply other threads:[~2017-11-30 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 8:01 [dpdk-dev] [RFC 1/2] net/tap: add eBPF to TAP device Ophir Munk
2017-11-30 8:01 ` [dpdk-dev] [RFC 2/2] net/tap: add eBPF instructions Ophir Munk
2017-11-30 16:54 ` Stephen Hemminger
2017-11-30 17:05 ` Thomas Monjalon [this message]
2017-11-30 17:20 ` Stephen Hemminger
2017-11-30 17:39 ` Thomas Monjalon
2017-12-05 7:59 ` Pascal Mazon
2017-12-13 9:58 ` Ophir Munk
2017-11-30 16:47 ` [dpdk-dev] [RFC 1/2] net/tap: add eBPF to TAP device Stephen Hemminger
2017-11-30 16:54 ` Thomas Monjalon
2017-12-05 7:53 ` Pascal Mazon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33612859.oYs3VmdAvV@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).