* [dpdk-dev] [PATCH] rcu: change format specifier in fprintf
@ 2019-06-03 20:46 Honnappa Nagarahalli
2019-06-05 12:18 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Honnappa Nagarahalli @ 2019-06-03 20:46 UTC (permalink / raw)
To: honnappa.nagarahalli, dev; +Cc: nd
Use %u to fix argument type mismatch in fprintf.
Coverity issue: 340074
Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
This patch is dependent on: http://patchwork.dpdk.org/patch/53455
lib/librte_rcu/rte_rcu_qsbr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_rcu/rte_rcu_qsbr.c b/lib/librte_rcu/rte_rcu_qsbr.c
index b4ed01045..de2546464 100644
--- a/lib/librte_rcu/rte_rcu_qsbr.c
+++ b/lib/librte_rcu/rte_rcu_qsbr.c
@@ -234,7 +234,7 @@ rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v)
id = i << __RTE_QSBR_THRID_INDEX_SHIFT;
while (bmap) {
t = __builtin_ctzl(bmap);
- fprintf(f, "%d ", id + t);
+ fprintf(f, "%u ", id + t);
bmap &= ~(1UL << t);
}
@@ -252,7 +252,7 @@ rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v)
id = i << __RTE_QSBR_THRID_INDEX_SHIFT;
while (bmap) {
t = __builtin_ctzl(bmap);
- fprintf(f, "thread ID = %d, count = %"PRIu64", lock count = %u\n",
+ fprintf(f, "thread ID = %u, count = %"PRIu64", lock count = %u\n",
id + t,
__atomic_load_n(
&v->qsbr_cnt[id + t].cnt,
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] rcu: change format specifier in fprintf
2019-06-03 20:46 [dpdk-dev] [PATCH] rcu: change format specifier in fprintf Honnappa Nagarahalli
@ 2019-06-05 12:18 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-06-05 12:18 UTC (permalink / raw)
To: Honnappa Nagarahalli; +Cc: dev, nd
03/06/2019 22:46, Honnappa Nagarahalli:
> Use %u to fix argument type mismatch in fprintf.
>
> Coverity issue: 340074
> Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-05 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 20:46 [dpdk-dev] [PATCH] rcu: change format specifier in fprintf Honnappa Nagarahalli
2019-06-05 12:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).