From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id D66A55A65
 for <dev@dpdk.org>; Mon,  2 Nov 2015 08:28:55 +0100 (CET)
Received: by wmeg8 with SMTP id g8so52596962wme.1
 for <dev@dpdk.org>; Sun, 01 Nov 2015 23:28:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind_com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=1IpFSSKKEUkyiJFr+yV5Tuj0S2f2tzIAe0s7VSgRogY=;
 b=nwYHZQzf7kKcuE+ogfRtJu1d6BsMWY3hF0EwXF6YBa2GtxOJFMtJbHy0095fhyJ54K
 4G5colZZskEz6/b+jU02fIVN7pn+2j7Q2dDhGNpHPBllmUeuUdsTfzMCslgkLch8wxUk
 jUJJYSsNR0DhFQEKJSg/p5JUnlfWlr6ZOtuu1qE5n9RArmAfos9T4WoEzzy6tZjurTtQ
 Tp8YI51/1vovd70XMVGzhqAb2kRRLR4uaxnkLCitg14JjMGlojhNt5Kru+f6ynFsoW08
 CQ5VHxiZuzCdi0xaLhLJ+yzNznllqDrBw3Svr7AswwadIFNkflWreUcO63z0uedO5XOR
 l+eA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=1IpFSSKKEUkyiJFr+yV5Tuj0S2f2tzIAe0s7VSgRogY=;
 b=bJF40pSXPnl1kJbI2qMZfhYxEOO2251QSE5wnV+lizszpJ+ATMgX4eOXuW18mdw5IC
 awYCC0L/zQRKfZinK/ygGz+iHWOvKMv7qNsMoS1iPzaA4Gvn1ovGl4v8w6NCUvMs/CGJ
 Sg7mTiurLiWa56tocUENc7ueA8DkB0+49LXUC0JJ6McDzotFHp3TXBBXGXhHCp68cvyv
 wR+aJoBHTUCqoJsZ3jg/H3wL7eIInbatrKe3lm84PPvt/VOQxlAyLTMwrUbnxUUX7QRi
 TH01P3zO3ffe9XHfUhrVSQEpiqP1XKIbnDzThoRKvxbu/NLtrPr+NLUmFsuvXCVwN2eY
 SPNA==
X-Gm-Message-State: ALoCoQl4fsJ/01eLJpcr7+Vd9Fn/USKRHtHpfbgfRyZIqcxKpsyE3Q4LLrKuhRHNl2UyRBgwb6Hi
X-Received: by 10.28.13.78 with SMTP id 75mr12435291wmn.24.1446449335697;
 Sun, 01 Nov 2015 23:28:55 -0800 (PST)
Received: from xps13.localnet (158.20.90.92.rev.sfr.net. [92.90.20.158])
 by smtp.gmail.com with ESMTPSA id u64sm16509853wmd.6.2015.11.01.23.28.53
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 01 Nov 2015 23:28:54 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Date: Mon, 02 Nov 2015 08:27:36 +0100
Message-ID: <3367355.V0LI0AXumx@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A923D11@SHSMSX104.ccr.corp.intel.com>
References: <1446098572-4409-1-git-send-email-helin.zhang@intel.com>
 <1825895.jnZdLtN9L6@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A923D11@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 07:28:56 -0000

2015-11-02 02:11, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-10-30 11:11, Helin Zhang:
> > > v7 changes:
> > > Modified RTE_ETH_INSET_SIZE_MAX from 128 to 1, to avoid ABI changes.
> > 
> > Why it would avoid ABI changes?
> > Have you passed the ABI checker?
> 
> Hi Thomas
> 
> The only structure modified is ' struct rte_eth_hash_filter_info ', where a new
> element (struct rte_eth_input_set_conf input_set_conf) was added. But I kept its
> structure the same size as another one (struct rte_eth_hash_global_conf global_conf)
> already in that union, they are both in 12 bytes. That means nothing changed for
> ' struct rte_eth_hash_filter_info'.

First, it should be justified in the commit message.
Second, I think it's wrong:
The union has struct rte_eth_hash_global_conf = enum + uint32_t + uint32_t
You are adding struct rte_eth_input_set_conf = uint16_t + uint16_t + enum + enum
I'm not sure we can assume the sizes are the same.

The ethdev ABI is already broken in this release. So maybe we can agree that
it's not a big deal but it should be notified in the release notes and,
in this case, you could keep your original patch with 128 enums.