From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id CFFD5378B; Mon, 12 Nov 2018 13:28:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 67ED721F47; Mon, 12 Nov 2018 07:28:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 12 Nov 2018 07:28:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=wbLcstDFAs3tMoTydEQpDOE+K+9j8pZ/FGTx16F8Vsk=; b=DYdeLV2ElFtV ApSgkD4EGwbEAWfDtjjzmyNTpnuvhBRD2E3Qg/kFydabgV46q0PQaJpKIv56GlIp Mzff7hDVnZzW6IiF0g+bL42SdlML97iFvmv0vfp/tpHzXm0ogbYA/dLPpCCDiL9t zcvfWn6/ecAHtno7dh0G0HsqdRYlUVw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wbLcstDFAs3tMoTydEQpDOE+K+9j8pZ/FGTx16F8V sk=; b=BvOU+JxnKzg6X1CyVoTEgoGhNI4xfUwUsxTtpuURp53tumurd1Eex6JE2 /qIrx8sr2GN7UlvWEQZHAhYfLG07ci2HFvMdm09/plJILS8/c4325YglWgWu9pBK RjiJf2MP2QG3AnX4NBp0mJV6o3RqRB+jCnE4QsMPVAPkQ7FuP0BwvQGQQs92l3mk Ta2P/I6fEPCcqpKFf7fFLcAuWdWHC4fba1x8MbtLDZNNSpPkYksgKzoZY3tmOtYo XKHQecAXDRwqQQbvWIbOpVyKyRWnnwdtNxjASYCmGhgdcQh2b6hPcYZjYK7sO5m2 8GG40Db8UMMwbNm3ZENiySpKhFtLA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CDE03E4679; Mon, 12 Nov 2018 07:28:46 -0500 (EST) From: Thomas Monjalon To: Jerin Jacob Cc: stable@dpdk.org, "dev@dpdk.org" , Qi Zhang , Xiao Wang , "sthemmin@microsoft.com" , "shaopeng.he@intel.com" , "Jacob, Jerin" Date: Mon, 12 Nov 2018 13:28:44 +0100 Message-ID: <3369863.oabFoVrSzJ@xps> In-Reply-To: <20181107065833.16756-2-jerin.jacob@caviumnetworks.com> References: <20181106114435.14770-1-jerin.jacob@caviumnetworks.com> <20181107065833.16756-1-jerin.jacob@caviumnetworks.com> <20181107065833.16756-2-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] eal: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 12:28:50 -0000 07/11/2018 07:59, Jerin Jacob: > Some toolchain has fls() definition in string.h as argument type int, > which is conflicting uint32_t argument type. >=20 > /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: > error: conflicting types for =E2=80=98fls=E2=80=99 > static inline int fls(uint32_t x) > ^~~ >=20 > /opt/marvell-tools-201/aarch64-marvell-elf/include/strings.h:59:6: > note: previous declaration of =E2=80=98fls=E2=80=99 was here > int fls(int) __pure2; >=20 > FreeBSD string.h also has fls() with argument as int type. > https://www.freebsd.org/cgi/man.cgi?query=3Dfls&sektion=3D3 >=20 > Fixing the conflict by using rte version of fls. >=20 > Fixes: ffe3ec811ef5 ("sched: introduce reciprocal divide") > Fixes: faf2b25c9f80 ("fm10k: support VMDQ in multi-queue configuration") > Cc: stable@dpdk.org >=20 > Suggested-by: Thomas Monjalon > Signed-off-by: Jerin Jacob Series applied, thanks