From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3002A0540; Mon, 13 Jul 2020 12:25:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CEDEF1D5E3; Mon, 13 Jul 2020 12:25:45 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 710131D5D3 for ; Mon, 13 Jul 2020 12:25:44 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 081085C010B; Mon, 13 Jul 2020 06:25:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 13 Jul 2020 06:25:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= uo5jDRkcrk7giSmBY1BlToMwtpUfpwVEtJL0N+S5PNU=; b=msUCEaMTx6qZlnXM 2vFmlb+zFRJ6MlBXm7Pf3X56pexV583KhrZqBuSccnsKvjwVbtCBKp5JpSQCV9xV T+w3p6XwYYw24YTQItxltEkyPaF7DtKjhMcCPBhz6qZrKwNwXnwLW/ybMPNNf542 tcvVfa8WQNbVhdNX3GocbzVHT0UUkFnp24wMHUWwToI6thhE7gLkosgvAF0juBXh MqXONPMN7vHNl9Z2vjanAH+YSwnhnpohKXgFPEnBRu/l3wH4wMCdEM1dBnRTQEhG YOooKD3HQ9rqkgQ/Noow7W5V9vLzNz6T9+ltJ/M7Zjas2uT7DjITOfGX3RbdLJ2E nFLg4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=uo5jDRkcrk7giSmBY1BlToMwtpUfpwVEtJL0N+S5P NU=; b=K3pAN0IO2rJGvfKQNoy4W1vnTfSaz9YJF59nskil/roRavyNNzM/kD7H2 6tWhtpRejLP1t+v0AVFzbjqM522x7zxAu8bHoloMp80dx7VadTgovZf2UrMW8bsV DnARi9H1MsCAPxUthQGqVjdu0atNfvHKufrwCy8rvnZwpNJ/33B4PC2fAbDsM/W5 etLlgmknOW0FFvLJ/g4r4JXnCGAaqza2mDoXIHLR63D10NO+uS3axDSo9SWUVZ8Y o65/TL4Hm7V8pvAqPI6tUitWGDghEI4dHwcPDJnZ2f/bARedczpB5TVp7jx70HPr QSobpjxA5/cUPpycXcPMYBjVQjJOQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdekgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E8FD30600B4; Mon, 13 Jul 2020 06:25:40 -0400 (EDT) From: Thomas Monjalon To: "Medvedkin, Vladimir" Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinj@marvell.com, mdr@ashroe.eu Date: Mon, 13 Jul 2020 12:25:39 +0200 Message-ID: <3373632.pBHoEykVWN@thomas> In-Reply-To: <87399890-4cd0-e102-2072-f5d6a12ffde9@intel.com> References: <6874799.X9nVCTG8Yq@thomas> <87399890-4cd0-e102-2072-f5d6a12ffde9@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/8] eal/x86: introduce AVX 512-bit type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/07/2020 12:23, Medvedkin, Vladimir: > Hi Thomas, > > On 10/07/2020 22:49, Thomas Monjalon wrote: > > Please Cc those who participated in the review previously. > > Adding Ray, Jerin, David. > > > > 10/07/2020 16:46, Vladimir Medvedkin: > >> + __m512i z; > >> + ymm_t y[RTE_X86_ZMM_SIZE / sizeof(ymm_t)]; > >> + xmm_t x[RTE_X86_ZMM_SIZE / sizeof(xmm_t)]; > >> + uint8_t u8[RTE_X86_ZMM_SIZE / sizeof(uint8_t)]; > >> + uint16_t u16[RTE_X86_ZMM_SIZE / sizeof(uint16_t)]; > >> + uint32_t u32[RTE_X86_ZMM_SIZE / sizeof(uint32_t)]; > >> + uint64_t u64[RTE_X86_ZMM_SIZE / sizeof(uint64_t)]; > >> + double pd[RTE_X86_ZMM_SIZE / sizeof(double)]; > >> +} __rte_aligned(RTE_X86_ZMM_SIZE) __rte_x86_zmm_t; > >> + > >> +#endif /* __AVX512F__ */ > > > > You were supposed to undef the macros above. > > It was intentional. It could be used later by other libs, like XMM_SIZE: > git grep -lw XMM_SIZE > lib/librte_acl/acl_gen.c > lib/librte_acl/acl_run.h > lib/librte_acl/rte_acl.h > lib/librte_eal/arm/include/rte_vect.h > lib/librte_eal/ppc/include/rte_vect.h > lib/librte_eal/x86/include/rte_vect.h > lib/librte_hash/rte_thash.h OK. Was it agreed with David to NOT undef? I may have missed this part.