From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 413321C923 for <dev@dpdk.org>; Sun, 13 May 2018 18:12:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ACBE424B58; Sun, 13 May 2018 12:12:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 13 May 2018 12:12:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=qrxoNzqi+GHQZQC11wHNrd5ljD F1ypQLGv1miFG3Bhs=; b=LjS+QvqecWZaRiIl5MHmGbY4ufgOAfsvet53zcFfZJ mqQLYduZ05UF7hsI2pbPzmHElJ5tZzdBhYZZQHHScB1etZVWEiHSki5Fhv9xY/Cq D23aWWn1Jq0xo2blL65tFbH52mfXrdHjzlFWKldXzW2E46eTfQPd8wwKAWun/zlP s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=qrxoNz qi+GHQZQC11wHNrd5ljDF1ypQLGv1miFG3Bhs=; b=mwMrGt34dUwggIIJPIu1dK Gr2EmfCoRHFK77flAd8FRaOOkPSOD5bvJPXSMMoJkhEzH2LjIYkuBmBaiZB+w/SO xIvnQkMiriMHyqLGs6ogt2pgMi8GOTQAZ1L8sYK1OB2f4RNL41GNS+XtArO3jKzG gb1j4DARyyKsOr00g6f8fUclbCQHrBpnLIpYPJJpV4Pc/CCJgoC9ICCG+3f88++Q Rd+OKi3pdpXEXjbn1i3otW2ia/lfV5lvvcQGaPQop5zddnVS4c/HQ9CmKg2M+J+H UM86UcHYa6JvVqRpQDJx0h8VSp4qdDIOcrv+4msYIsTrQ43jOhc0F7tNpv7hIH4g == X-ME-Sender: <xms:9WP4WljdJQkdI8Zffy0izbQiGXaFZwHvW7gQLPoPxtt84z-u4mp68Q> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DDA47E4855; Sun, 13 May 2018 12:12:36 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ophir Munk <ophirmu@mellanox.com> Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>, Olga Shern <olgas@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com> Date: Sun, 13 May 2018 18:12:35 +0200 Message-ID: <3374507.afEf5z8BbC@xps> In-Reply-To: <1526225995-31378-2-git-send-email-ophirmu@mellanox.com> References: <1525962108-15215-1-git-send-email-ophirmu@mellanox.com> <1526225995-31378-1-git-send-email-ophirmu@mellanox.com> <1526225995-31378-2-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/mlx4: advertise supported RSS hash functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sun, 13 May 2018 16:12:38 -0000 13/05/2018 17:39, Ophir Munk: > info->speed_capa = > - ETH_LINK_SPEED_1G | > - ETH_LINK_SPEED_10G | > - ETH_LINK_SPEED_20G | > - ETH_LINK_SPEED_40G | > - ETH_LINK_SPEED_56G; > + ETH_LINK_SPEED_1G | > + ETH_LINK_SPEED_10G | > + ETH_LINK_SPEED_20G | > + ETH_LINK_SPEED_40G | > + ETH_LINK_SPEED_56G; Not sure why you re-indent. For info, line continuation in control statements must be done with 2 tabs: http://dpdk.org/doc/guides/contributing/coding_style.html#general In this case, it is not a control statement, so I guess 1 or 2 tabs can be accepted.