From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 16BB347D1 for ; Mon, 28 Mar 2016 15:44:41 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id 20so17823873wmh.1 for ; Mon, 28 Mar 2016 06:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=QAE5K+nDFT6DApAabcaAwMTdKAu+EjFCWQECtTfO4rY=; b=qgJBER+dCm4QZUu0DCLOyNubqPUSeMQFTR+SSfxxydRAXOMIvxCz8aYDVEnM5JSp/t AhiXScA01wFyK5WFjm48ljLljjR5Z/aUwwCZ95zIIX/gme4LE9ssLuVDxHtig3dMyjFK y4V52QnxOHZQNiZeidmeFlwt6yzbhOC+l81VE2IH1eMYdVqvK58cBnzcXKrgquJK1ZP4 SwdFjgGuQbmdPsq9jKkzMYxCEOeTMPI+sN5pCUjHqJ3ChbF1cynpSMryrAK5i+TnIICp s7XzR7gbMlLkXVnA1pLupk9Naj+1YnJw0WAzlKvmk+jvUg6NTbW+TZ4gLvfqzV9Bq3z9 y3Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=QAE5K+nDFT6DApAabcaAwMTdKAu+EjFCWQECtTfO4rY=; b=LhgRP1p5TcqEvFrhN96o/ab3OgWQU5xCCapjaMQtBso3jO++1hB0Ml3dQSYIHlypGd 6Db55m3jg6pPMORR9uyTeVn7BxzZFFtM8PHSgS4Q50wGm1L+WkS1V4P1A1Z+aCtD6c3K qIa9huPsy9X3D3xOi/6Y9+EbpfPEo9R1BCvSXImxwlfW7mzoPIoMqHYjQ3+XBokT2GD8 DPAcdnFgdcxQRYB0uTk3Hj/C48kmxxlIAvApoeYHy2jJa+Q3e9q/lYMoLVkdCglCvdsb w/pIjqMArzIEEIWo+loFRV0tc22SN9a90YFFwCTVZLYqAPmOaoJQbbVCiqc7cPydSZvC VDnA== X-Gm-Message-State: AD7BkJJfvV/Rr1BJ0fDeQaSHezBp9njHK9V6ZJPJ+xC8/ihyMogJ6Mjx5Q07lUI9HPIunH/8 X-Received: by 10.28.85.137 with SMTP id j131mr10397041wmb.15.1459172680907; Mon, 28 Mar 2016 06:44:40 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id av3sm24885302wjc.44.2016.03.28.06.44.39 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Mar 2016 06:44:39 -0700 (PDT) From: Thomas Monjalon To: Marc Cc: "Zhang, Helin" , "Xu, Qian Q" , "Xing, Beilei" , dev@dpdk.org, "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Glynn, Michael J" Date: Mon, 28 Mar 2016 15:42:46 +0200 Message-ID: <3378985.okHjTtIZOy@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com> <10133718.H4CGZOGkuk@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2016 13:44:41 -0000 Hi Marc, 2016-03-27 21:39, Marc: > On 27 March 2016 at 11:53, Thomas Monjalon > wrote: > > 2016-03-26 11:24, Marc: > > > On 26 March 2016 at 09:08, Thomas Monjalon > > > wrote: > > > > 2016-03-25 22:30, Marc: > > > > > From v9 to v10 patchset the values ETH_LINK_SPEED_AUTONEG and > > > > ETH_LINK_SPEED_FIXED were flipped. Reverting this makes it work: [...] > > > > > I think having autoneg == 0 is better. Do you agree Thomas? > > > > > > > > No I do not agree, because this flag is now used also for > > > > rte_eth_link.link_autoneg. > > > > So it is more logic to set it to 1. > > > > > > Having to explicitly specify ETH_LINK_SPEED_AUTONEG in link_speeds during > > > port configuration for achieving auto-negociation, which is what 98% of > > > applications will use, seems anti-natural to me and breaks existing > > > applications. > > > > Yes, you're right. We have to avoid apps modifications. > > By keeping autoneg the default behaviour (value 0), we avoid issues. > > > > > The only benefit of your approach is not to have another macro #define > > > ETH_LINK_AUTONEG 1, which is marginal IMHO. > > > > Yes, you're right. > > I suggest adding 2 macros for rte_eth_link.link_autoneg: > > #define ETH_LINK_FIXED 0 /**< No autonegotiation. */ > > #define ETH_LINK_AUTONEG 1 /**< Autonegotiated. */ > > > > and keep these ones to use with rte_eth_conf.link_speeds and > > rte_eth_dev_info.speed_capa: > > #define ETH_LINK_SPEED_AUTONEG (0 << 0) /**< Autonegotiate (all speeds) */ > > #define ETH_LINK_SPEED_FIXED (1 << 0) /**< Disable autoneg (fixed speed) */ > > > > Opinions? > > Agree on all of them. I can add them in the (hopefully) final v14, once all > or main drivers have been tested. It would be better to make the v14 as soon as possible to let others test the latest revision. Thanks