From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 8953F1075
 for <dev@dpdk.org>; Tue, 14 Mar 2017 10:53:28 +0100 (CET)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
 (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id ED4487E9C8;
 Tue, 14 Mar 2017 09:53:28 +0000 (UTC)
Received: from [10.36.117.76] (ovpn-117-76.ams2.redhat.com [10.36.117.76])
 by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 v2E9rOn5004078
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 14 Mar 2017 05:53:27 -0400
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, dev@dpdk.org
References: <1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1488534682-3494-2-git-send-email-yuanhan.liu@linux.intel.com>
 <cd83e9e3-426d-c936-a666-625dcfa9fe59@redhat.com>
Cc: Harris James R <james.r.harris@intel.com>,
 Liu Changpeng <changpeng.liu@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <337dbdcd-0913-dd1f-5cba-15844a7380b1@redhat.com>
Date: Tue, 14 Mar 2017 10:53:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <cd83e9e3-426d-c936-a666-625dcfa9fe59@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.26]); Tue, 14 Mar 2017 09:53:29 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 01/17] vhost: introduce driver features
	related APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Mar 2017 09:53:28 -0000



On 03/14/2017 10:46 AM, Maxime Coquelin wrote:
>
>
> On 03/03/2017 10:51 AM, Yuanhan Liu wrote:
>> Introduce few APIs to set/get/enable/disable driver features.
>>
>> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>> ---
>>  lib/librte_vhost/rte_vhost_version.map | 10 ++++
>>  lib/librte_vhost/rte_virtio_net.h      |  9 ++++
>>  lib/librte_vhost/socket.c              | 90
>> ++++++++++++++++++++++++++++++++++
>>  3 files changed, 109 insertions(+)
>
> Nice!
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> I wonder whether we could protect from setting/enabling/disabling
> features once negotiation is done?

Oh, I forgot one comment on this patch.
Since these new functions are part to the API, shouldn't them be
documented?

Maxime