From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B31E3A04DD; Wed, 18 Nov 2020 19:37:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7806D592C; Wed, 18 Nov 2020 19:37:52 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 2CFC0F90 for ; Wed, 18 Nov 2020 19:37:50 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id p19so4703740wmg.0 for ; Wed, 18 Nov 2020 10:37:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=bGaaU8Rzm6I7MTFo5o0/+jPO7z7V9SLKlzKSO63GNWI=; b=t8ewb9qAEZ7Gh77oZY8In30x479z0GkZvR4M508ek4snr8n+9jIpsStbtZEV3oouFv g6d8GGGwAfuwcgZb+MxNePIzQ1r0FxDUTJ3CY25zRXBzpnaCQVGQjgLy+ao2fZzC/P6r 0LHXf88M5wpPuTQfMvE+iJmvfbKcUGbmEn85wwKNcizjnn9xx+9HTcQnHRtd1KmJPgc6 Aqs0rVmKaJ+C61m/vwULQojN5k51+/nNL+n5hcddN4DyJxfEilAslNdCySUtR8l7tgH6 knaFnBNQc02qtoeYfYXMJ6qQVDdY+wDy0k9M4qWoG/vTlDEdBBw37x3tuAe6C/0E5IK9 3Avg== X-Gm-Message-State: AOAM533lk9iAycaxJvpNubVcBTOabIQOVZQdgCK87E3RfShVkVr1dbxq BTE+KQznSkPZ7OPbuVAn+jY= X-Google-Smtp-Source: ABdhPJwoY3mQVfZcQJjcFGe/6D8YRAj+TsCI3nbk2tonoWVyAs6lfyrekXVjHwX81PKnFKP4K3TeeQ== X-Received: by 2002:a1c:c343:: with SMTP id t64mr498951wmf.140.1605724668880; Wed, 18 Nov 2020 10:37:48 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 8sm3622224wmg.28.2020.11.18.10.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 10:37:47 -0800 (PST) Message-ID: <3381c6393a6b77be78624f4401d6760c22ebdb3b.camel@debian.org> From: Luca Boccassi To: Conor Walsh , bruce.richardson@intel.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, stuart.schacher@broadcom.com, venkatkumar.duvvuru@broadcom.com, michael.wildt@broadcom.com Cc: dev@dpdk.org, linglix.chen@intel.com, thomas@monjalon.net Date: Wed, 18 Nov 2020 18:37:47 +0000 In-Reply-To: <20201118181103.3865787-1-conor.walsh@intel.com> References: <20201112113537.1996073-1-conor.walsh@intel.com> <20201118181103.3865787-1-conor.walsh@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-11-18 at 18:11 +0000, Conor Walsh wrote: > On some systems Wformat-nonliteral and Wformat-security could not be > checked without Wformat also being specified this causes a compile > warning on these systems. This patchset adds Wformat to > config/meson.build and fixes some format issues that this exposed. >=20 > --- >=20 > v2: > - expand explaination of patches > - suppress false postives in icc > - add fixes for format issues >=20 > Conor Walsh (2): > build: fix gcc compile warnings by adding wformat > net/bnxt: fix format characters for unsigned values >=20 > config/meson.build | 3 ++- > drivers/net/bnxt/tf_core/tf_core.c | 8 ++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) Looks good to me, but it should be cc'ed to stable as well I think --=20 Kind regards, Luca Boccassi