From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 76ECA5688
for <dev@dpdk.org>; Thu, 28 Mar 2019 00:12:43 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0418521C86;
Wed, 27 Mar 2019 19:12:43 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 27 Mar 2019 19:12:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=9AA+bnQc/qCcTYAGojO2yzZSIcT/wTGukq+XgKrAAYE=; b=YLjO99fEcKt6
aijItJbwQhnWm0sZdUOIRctDccJRMAOE5fvt3VGig1k39WpTFjhLa+UJM8yR7SoS
/PaDZoTdplop2u62eoFZls6FceWSwGa7SFUdDzKnWrbp5f6efkJ+7uFJC43Q1TqR
G692zlsH2Lsev4MNJIhfPPEoS0H1Kt8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=9AA+bnQc/qCcTYAGojO2yzZSIcT/wTGukq+XgKrAA
YE=; b=3r9FrCQlku06SsQL7eGqtIvRO47MUS+wCD+xIX7hXkbXUH0+8crPY9x5G
YWaZNEB5ngR0GSlygGsCpyEzvXxxScbGS6Bo80GAjxEa/Vqw6tvwM+fN3h93urPQ
yCtqD9pbK4+LciqIC+Wsy4I29I3JCh9ISj3om689eD8oowS7lI8isg1Fon2mvHXM
/9yMMKdsNsM9ZJizBp0NeX7txx4VZBJwr2LhBRHDKzCRb0tlnGi7Q3xkJEMyzFab
xLSDC4hlWBnFNgU7JB6Mro4J1UO8qPpVFIQqCGOdBRTs9qXx0Phbmrj3btAvpFcP
9kG1WEK9MjlYdXbET4B2yQOUCXFUg==
X-ME-Sender: <xms:aAOcXGKeq4sJRRjPVf645tnC-8Nbs0wy-G_iEF0ZmpsbNyd1ur6A7Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeefgddulecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho
mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:aAOcXKC7c-_t8_BE1UR9hU2jG4BiJweUDGlVtuYVKPDgyjzu0HkahA>
<xmx:aAOcXPizNBhIYuQPn40pI0McHfQ1fD4NCxuKDagK8P7N5YQFwWpZEA>
<xmx:aAOcXEPDiW-MRETVrpWxLxJkYtBA51oZTMqTgQvSbanlocPojh_z5A>
<xmx:agOcXHFI5i3yOOVU-1tBYshmThSUYlKZZV6YU6LFtQMhB59BtgIPig>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 134F310310;
Wed, 27 Mar 2019 19:12:38 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Gage Eads <gage.eads@intel.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com, arybchenko@solarflare.com,
bruce.richardson@intel.com, konstantin.ananyev@intel.com, gavin.hu@arm.com,
Honnappa.Nagarahalli@arm.com, nd@arm.com, chaozhu@linux.vnet.ibm.com,
jerinj@marvell.com, hemant.agrawal@nxp.com, david.marchand@redhat.com
Date: Thu, 28 Mar 2019 00:12:37 +0100
Message-ID: <3387191.pRBmEOjPGs@xps>
In-Reply-To: <20190304205133.2248-2-gage.eads@intel.com>
References: <20190222154640.22029-1-gage.eads@intel.com>
<20190304205133.2248-1-gage.eads@intel.com>
<20190304205133.2248-2-gage.eads@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange
(x86-64 only)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Mar 2019 23:12:43 -0000
04/03/2019 21:51, Gage Eads:
> --- a/lib/librte_eal/common/include/generic/rte_atomic.h
> +++ b/lib/librte_eal/common/include/generic/rte_atomic.h
> +#if defined(RTE_ARCH_X86_64)
> +/**
> + * 128-bit integer structure.
> + */
> +RTE_STD_C11
> +typedef struct {
> + RTE_STD_C11
> + union {
> + uint64_t val[2];
> + __int128 int128;
> + };
> +} __rte_aligned(16) rte_int128_t;
Why adding an arch-specific definition in a generic file?
Can we move it to the x86_64 file?
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 13C0BA05D3
for <public@inbox.dpdk.org>; Thu, 28 Mar 2019 00:12:45 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 6E1C6568A;
Thu, 28 Mar 2019 00:12:44 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 76ECA5688
for <dev@dpdk.org>; Thu, 28 Mar 2019 00:12:43 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0418521C86;
Wed, 27 Mar 2019 19:12:43 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 27 Mar 2019 19:12:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=9AA+bnQc/qCcTYAGojO2yzZSIcT/wTGukq+XgKrAAYE=; b=YLjO99fEcKt6
aijItJbwQhnWm0sZdUOIRctDccJRMAOE5fvt3VGig1k39WpTFjhLa+UJM8yR7SoS
/PaDZoTdplop2u62eoFZls6FceWSwGa7SFUdDzKnWrbp5f6efkJ+7uFJC43Q1TqR
G692zlsH2Lsev4MNJIhfPPEoS0H1Kt8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=9AA+bnQc/qCcTYAGojO2yzZSIcT/wTGukq+XgKrAA
YE=; b=3r9FrCQlku06SsQL7eGqtIvRO47MUS+wCD+xIX7hXkbXUH0+8crPY9x5G
YWaZNEB5ngR0GSlygGsCpyEzvXxxScbGS6Bo80GAjxEa/Vqw6tvwM+fN3h93urPQ
yCtqD9pbK4+LciqIC+Wsy4I29I3JCh9ISj3om689eD8oowS7lI8isg1Fon2mvHXM
/9yMMKdsNsM9ZJizBp0NeX7txx4VZBJwr2LhBRHDKzCRb0tlnGi7Q3xkJEMyzFab
xLSDC4hlWBnFNgU7JB6Mro4J1UO8qPpVFIQqCGOdBRTs9qXx0Phbmrj3btAvpFcP
9kG1WEK9MjlYdXbET4B2yQOUCXFUg==
X-ME-Sender: <xms:aAOcXGKeq4sJRRjPVf645tnC-8Nbs0wy-G_iEF0ZmpsbNyd1ur6A7Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeefgddulecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho
mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:aAOcXKC7c-_t8_BE1UR9hU2jG4BiJweUDGlVtuYVKPDgyjzu0HkahA>
<xmx:aAOcXPizNBhIYuQPn40pI0McHfQ1fD4NCxuKDagK8P7N5YQFwWpZEA>
<xmx:aAOcXEPDiW-MRETVrpWxLxJkYtBA51oZTMqTgQvSbanlocPojh_z5A>
<xmx:agOcXHFI5i3yOOVU-1tBYshmThSUYlKZZV6YU6LFtQMhB59BtgIPig>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 134F310310;
Wed, 27 Mar 2019 19:12:38 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Gage Eads <gage.eads@intel.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com, arybchenko@solarflare.com,
bruce.richardson@intel.com, konstantin.ananyev@intel.com, gavin.hu@arm.com,
Honnappa.Nagarahalli@arm.com, nd@arm.com, chaozhu@linux.vnet.ibm.com,
jerinj@marvell.com, hemant.agrawal@nxp.com, david.marchand@redhat.com
Date: Thu, 28 Mar 2019 00:12:37 +0100
Message-ID: <3387191.pRBmEOjPGs@xps>
In-Reply-To: <20190304205133.2248-2-gage.eads@intel.com>
References: <20190222154640.22029-1-gage.eads@intel.com>
<20190304205133.2248-1-gage.eads@intel.com>
<20190304205133.2248-2-gage.eads@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange
(x86-64 only)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190327231237.YO50mj-lqIouodKRfB7I9jHDzTbafesAJZTaowuQ4E4@z>
04/03/2019 21:51, Gage Eads:
> --- a/lib/librte_eal/common/include/generic/rte_atomic.h
> +++ b/lib/librte_eal/common/include/generic/rte_atomic.h
> +#if defined(RTE_ARCH_X86_64)
> +/**
> + * 128-bit integer structure.
> + */
> +RTE_STD_C11
> +typedef struct {
> + RTE_STD_C11
> + union {
> + uint64_t val[2];
> + __int128 int128;
> + };
> +} __rte_aligned(16) rte_int128_t;
Why adding an arch-specific definition in a generic file?
Can we move it to the x86_64 file?