From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F4A5A0545; Tue, 21 Jun 2022 17:35:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 077ED4069C; Tue, 21 Jun 2022 17:35:33 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id C56A240151 for ; Tue, 21 Jun 2022 17:35:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7F52C5C0162; Tue, 21 Jun 2022 11:35:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 21 Jun 2022 11:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1655825731; x= 1655912131; bh=3JuZLmb6rGpZMEVw9PsHLfJH9orDFPe1ppgTr9WsSpg=; b=t SpRegTh5Q8soK4+zoF8UGoIFoBwOzimsrRt0kIo4d2VQECMTweVOAst64D3ZCeqB aNeVkTGjlNA/zV6Rt+2rT5qRfByrZOMeMhIK41pAFvru0xqbXRcJnflMFQjYMirz KrjLJoS+oyMCmtBoXMznECc/5C2Lh2GIKAxjgZKaS2pfdoognfDiWnqqCeKPA1kE ABY8kVfspvR1W7+hy30RshRyl7bnq9XKrl61IGwjOMaH+9O8JVs+HSolWY5Ke6pI C6G3BP3TTOZ5YUEBBo/7Ktro4gKkutLFvQ8mBu18dFmODwjLXMI8FZ6l+cqEp2Sv oShbpLWhj1XYcuIhf8p5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655825731; x= 1655912131; bh=3JuZLmb6rGpZMEVw9PsHLfJH9orDFPe1ppgTr9WsSpg=; b=b T9712MnEITAQ2EdgzjgdHJ+OxVvHggB+z0mgQIcXRBXOvmKetsutYo/Qm0cBA8Mr hY4wmS6qOwN5e1pwEYd6iHW3B+fjACMinJE2HsX9ZZIuW8+yNgU5mNYwFH9soTgS xDupnmxBdwJGrQNIwhOWlLitnIqTTwl8/X7v2m56gw/M1Pa4uEFcIilAV9IJudUu EGqRRLZlQ7FiWoLNjsj0/KjICkSG9F1FCHf/Iex4IqJ6Koo8AY5aFuBpmxRMY2a5 h7OqcBDnpIiK0rbO/hA84wCBDXbQ9aj9NKuKrdIbB4Se5L1+4UMUg99hOSxfbloj TsTmqK/2DW0rKieOSlqAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeffedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Jun 2022 11:35:30 -0400 (EDT) From: Thomas Monjalon To: "Richardson, Bruce" Cc: "dev@dpdk.org" , "Laatz, Kevin" , "Pai G, Sunil" Subject: Re: [PATCH] dma/idxd: fix missing default for workqueue options Date: Tue, 21 Jun 2022 17:35:28 +0200 Message-ID: <3392561.3Lj2Plt8kZ@thomas> In-Reply-To: References: <20220617111750.356481-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 20/06/2022 06:09, Pai G, Sunil: > > From: Richardson, Bruce > > Sent: Friday, June 17, 2022 4:48 PM > > To: dev@dpdk.org > > Cc: Laatz, Kevin ; Pai G, Sunil > > ; Richardson, Bruce > > Subject: [PATCH] dma/idxd: fix missing default for workqueue options > > > > When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the default > > value used by argparse is None. This leads to later errors which are > > expecting an array value: > > > > TypeError: 'NoneType' object is not iterable > > > > This is fixed by specifying that the empty array should be the default if > > no flags are passed. > > > > Fixes: 94b0f04dc0e3 ("dma/idxd: add generic option for queue config") > > > > Signed-off-by: Bruce Richardson > > --- > > LGTM > Acked-by: Sunil Pai G Applied, thanks.