From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B42042951 for ; Wed, 24 Aug 2016 10:12:00 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3759381233; Wed, 24 Aug 2016 08:12:00 +0000 (UTC) Received: from [10.36.7.65] (vpn1-7-65.ams2.redhat.com [10.36.7.65]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7O8Bwgs019065 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 24 Aug 2016 04:11:59 -0400 To: Yuanhan Liu , dev@dpdk.org References: <1471510123-4984-1-git-send-email-yuanhan.liu@linux.intel.com> <1471510123-4984-8-git-send-email-yuanhan.liu@linux.intel.com> From: Maxime Coquelin Message-ID: <33936312-b630-1a4e-e478-b028dc264962@redhat.com> Date: Wed, 24 Aug 2016 10:11:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471510123-4984-8-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 24 Aug 2016 08:12:00 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 7/7] vhost: simplify features set/get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2016 08:12:01 -0000 On 08/18/2016 10:48 AM, Yuanhan Liu wrote: > No need to use a pointer to store/retrieve features. > > Signed-off-by: Yuanhan Liu > --- > lib/librte_vhost/vhost_user.c | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index ef4a0c1..eee99e9 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -155,23 +155,22 @@ vhost_user_reset_owner(struct virtio_net *dev) > /* > * The features that we support are requested. > */ > -static int > -vhost_user_get_features(uint64_t *pu) > +static uint64_t > +vhost_user_get_features(void) > { > - *pu = VHOST_FEATURES; > - return 0; > + return VHOST_FEATURES; > } This is not the topic of this series, but I wonder if it could make sense to be able to override supported features at device init time. It may not match with the orignal purpose of supported features, but could be useful at least for testing without recompilation. For this patch: Reviewed-by: Maxime Coquelin Thanks, Maxime