From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59C96A046B for ; Thu, 27 Jun 2019 19:05:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 70A662B82; Thu, 27 Jun 2019 19:05:15 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DD8011E2F for ; Thu, 27 Jun 2019 19:05:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6F9B522125; Thu, 27 Jun 2019 13:05:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 27 Jun 2019 13:05:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vUc1z5pFYmub15wMawla3NG1d63Ek7/bQBS5rDKwzq0=; b=I+7WC49HcMns U10Uke2G6Mk9iYWogomD1CvZrqLaEZHC0pmVxDceyvwg7KeE9srB1flxMe4JdNW0 4q6VfiEngA5j2ZIqDGPlW5L/RmPRsY8dYjtNG3ypaJscL3HHKzhTHnXO/nSWWS35 7YbCH1Oh5aW2/uhUQDo9H7PsJxafkGM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=vUc1z5pFYmub15wMawla3NG1d63Ek7/bQBS5rDKwz q0=; b=Bd9/Vg1n20LxOcFcmiA2z9ZeXoTe3jkKxcw5EgvECChF544N/rUwKDrSw blgPNN8RkAsSmPedeYnsYlxK4DX8aeK/XJ6f4zBW3J4971vCj59J2LBJX4345stN DSCrGcIKpWcNPaihtNUcgfg89+/CKfYyLkh00+rY6kcMCxd1npmiEi53Q3F3xjHX S7MFgL4kUAYFB+N2p+rPuBu50DnebsFJy8zGpx3K37u4SxfbBFJsd5LAjK4w0ioT EqeB+V/hEYBNFTUu7DkylYtCOvgokNTQPFtZnyATnoGTonqylla+7OTesTnbPiqo aWJeznuLIC19dd4TDbQe8d9xMToMA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudekgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0D606380089; Thu, 27 Jun 2019 13:05:10 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: David Marchand , benjamin.walker@intel.com, jerinj@marvell.com, anatoly.burakov@intel.com, maxime.coquelin@redhat.com, hemant.agrawal@nxp.com, honnappa.nagarahalli@arm.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Date: Thu, 27 Jun 2019 19:05:09 +0200 Message-ID: <3396376.MrP74pr19o@xps> In-Reply-To: <1560505157-9769-1-git-send-email-david.marchand@redhat.com> References: <20190530174819.1160221-1-benjamin.walker@intel.com> <1560505157-9769-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/3] Improve automatic selection of IOVA mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Help in review would be much appreciated here, thanks. 14/06/2019 11:39, David Marchand: > In SPDK, not all drivers are registered with DPDK at start up time. > Previously, that meant DPDK always chose to set itself up in IOVA_PA > mode. Instead, when the correct iova choice is unclear based on the > devices and drivers known to DPDK at start up time, use other heuristics > (such as whether /proc/self/pagemap is accessible) to make a better > choice. > > This enables SPDK to run as an unprivileged user again without requiring > users to explicitly set the iova mode on the command line. > > > Changelog since v1: > - I took over the series following experiments and discussions with Ben > and others, squashed Ben patches as two patches focusing on the main > issues, > - introduced a fix on KNI, > - on the EAL bits, > > - added log on which IOVA mode has been selected, > - updated BSD EAL, > - in Linux EAL, moved KNI special case after IOVA selection, > - in Linux EAL, added check on forced mode wrt physical addresses > availability, > > - on the PCI bus driver bits, > > - enforced the checks in the common code of the PCI bus, > - added debug logs to track why a iova mode has been chosen per device, > - added BSD part, > - in Linux part, checked that VFIO is enabled, > - in Linux part, defaulted to DC if a driver supports both PA and VA,