From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id 58AA32BAA for ; Wed, 10 May 2017 21:09:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1414; q=dns/txt; s=iport; t=1494443340; x=1495652940; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=pwIcfwodPRStF4VZkyjQjuh4dFTql7pYyCv22UC1lHE=; b=V3JtNgm48rqHBxMFuLA7ny4qBkga/S+KP33c2iv+hLE0QmV/nIcpZPHR +6Qu9yRVgGIeRzB+KiZMElbSdYe97xY0fe2RGbZbjnUmKenZeutAn5Hsd 1XpKc5Z0+Yg7pGJVOFgTVoe3ZNh2XjwX9YEMoUynxqiQkmOJvqQqTSlT0 w=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DGAAB7ZBNZ/4cNJK1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1WBboNpihiRWJVygg+GJAKFAD8YAQIBAQEBAQEBayiFFgEFIwQ?= =?us-ascii?q?RQRALGAICJgICVwYBDAYCAQGKHbJogWw6inUBAQEBAQEBAQEBAQEBAQEBAQEgg?= =?us-ascii?q?QuFVIFeK4JwhDKDP4JgAQSeCpMbiwKGaZRDHziBCk8hFYdXJDaGXII9AQEB?= X-IronPort-AV: E=Sophos;i="5.38,320,1491264000"; d="scan'208";a="241850286" Received: from alln-core-2.cisco.com ([173.36.13.135]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 May 2017 19:08:59 +0000 Received: from [10.150.214.135] ([10.150.214.135]) by alln-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id v4AJ8xSQ001722; Wed, 10 May 2017 19:08:59 GMT To: Wei Dai , wenzhuo.lu@intel.com, konstantin.ananyev@intel.com Cc: dev@dpdk.org References: <1494399602-33955-1-git-send-email-wei.dai@intel.com> From: Roger B Melton Message-ID: <339650e6-40ea-b801-2c0a-6994038a6487@cisco.com> Date: Wed, 10 May 2017 15:08:59 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1494399602-33955-1-git-send-email-wei.dai@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 19:09:00 -0000 -stable@dpdk.org per Thomas I know this patch has already been applied but to complete the loop, I have applied the patch to 17.05-rc4 and verified within my application that the NULL function pointer issue for ixgbe_vf has been resolved. Regards, Roger On 5/10/17 3:00 AM, Wei Dai wrote: > hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not > be called directly. It had better be replaced by calling > ixgbe_get_media_type( ) to avoid crash. > > Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai Tested-by Roger B Melton > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index ec667d8..ed2baec 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) > hw->mac.get_link_status = true; > > if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && > - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { > + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { > speed = hw->phy.autoneg_advertised; > if (!speed) > ixgbe_get_link_capabilities(hw, &speed, &autoneg);