DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/test: fix for icc compilation error
@ 2016-06-22 16:13 Deepak Kumar Jain
  2016-06-22 16:22 ` John Griffin
  0 siblings, 1 reply; 3+ messages in thread
From: Deepak Kumar Jain @ 2016-06-22 16:13 UTC (permalink / raw)
  To: dev; +Cc: john.griffin, arkadiuszx.kusztal, Deepak Kumar Jain

Icc complains about variable may be used without setting.

Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test)

Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
---
 app/test/test_cryptodev_perf.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/app/test/test_cryptodev_perf.c b/app/test/test_cryptodev_perf.c
index e1adc99..e484cbb 100644
--- a/app/test/test_cryptodev_perf.c
+++ b/app/test/test_cryptodev_perf.c
@@ -2458,18 +2458,17 @@ test_perf_aes_sha(uint8_t dev_id, uint16_t queue_id,
 
 	/* Generate a burst of crypto operations */
 	for (i = 0; i < (pparams->burst_size * NUM_MBUF_SETS); i++) {
-		struct rte_mbuf *m = test_perf_create_pktmbuf(
+		mbufs[i] = test_perf_create_pktmbuf(
 				ts_params->mbuf_mp,
 				pparams->buf_size);
 
-		if (m == NULL) {
+		if (mbufs[i] == NULL) {
 			printf("\nFailed to get mbuf - freeing the rest.\n");
 			for (k = 0; k < i; k++)
 				rte_pktmbuf_free(mbufs[k]);
 			return -1;
 		}
 
-		mbufs[i] = m;
 	}
 
 
@@ -2587,18 +2586,17 @@ test_perf_snow3g(uint8_t dev_id, uint16_t queue_id,
 
 	/* Generate a burst of crypto operations */
 	for (i = 0; i < (pparams->burst_size * NUM_MBUF_SETS); i++) {
-		struct rte_mbuf *m = test_perf_create_pktmbuf(
+		mbufs[i] = test_perf_create_pktmbuf(
 				ts_params->mbuf_mp,
 				pparams->buf_size);
 
-		if (m == NULL) {
+		if (mbufs[i] == NULL) {
 			printf("\nFailed to get mbuf - freeing the rest.\n");
 			for (k = 0; k < i; k++)
 				rte_pktmbuf_free(mbufs[k]);
 			return -1;
 		}
 
-		mbufs[i] = m;
 	}
 
 	tsc_start = rte_rdtsc_precise();
-- 
2.5.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] app/test: fix for icc compilation error
  2016-06-22 16:13 [dpdk-dev] [PATCH] app/test: fix for icc compilation error Deepak Kumar Jain
@ 2016-06-22 16:22 ` John Griffin
  2016-06-27 10:32   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: John Griffin @ 2016-06-22 16:22 UTC (permalink / raw)
  To: Deepak Kumar Jain, dev; +Cc: arkadiuszx.kusztal

On 22/06/16 17:13, Deepak Kumar Jain wrote:
> Icc complains about variable may be used without setting.
>
> Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test)
>
> Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Acked-by: John Griffin <john.griffin@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] app/test: fix for icc compilation error
  2016-06-22 16:22 ` John Griffin
@ 2016-06-27 10:32   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-06-27 10:32 UTC (permalink / raw)
  To: Deepak Kumar Jain; +Cc: dev, John Griffin, arkadiuszx.kusztal

> > Icc complains about variable may be used without setting.
> >
> > Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test)
> >
> > Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
> Acked-by: John Griffin <john.griffin@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-27 10:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-22 16:13 [dpdk-dev] [PATCH] app/test: fix for icc compilation error Deepak Kumar Jain
2016-06-22 16:22 ` John Griffin
2016-06-27 10:32   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).