From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5914A04B1; Wed, 9 Sep 2020 07:20:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C1341BF8F; Wed, 9 Sep 2020 07:20:07 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 18DAF1BF8D for ; Wed, 9 Sep 2020 07:20:04 +0200 (CEST) IronPort-SDR: kisqy/0XEx2RKSMl4WzNydx9mqZEIZjIWtu6bxBATmVp6hxCCim08iBzWle92fY+3N4HFHbBc+ ZUisjqhGv97A== X-IronPort-AV: E=McAfee;i="6000,8403,9738"; a="176331408" X-IronPort-AV: E=Sophos;i="5.76,408,1592895600"; d="scan'208";a="176331408" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 22:20:04 -0700 IronPort-SDR: OFkaszItTO6iOYniA/+lyOUO8PUfuPfNFfbfUqE+5vwTYngJf46ua3+BxDYTDhu1t3XCp4bAdQ nyWG+qCl7X1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,408,1592895600"; d="scan'208";a="300031352" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 08 Sep 2020 22:20:03 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Sep 2020 22:20:03 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Sep 2020 13:20:01 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Wed, 9 Sep 2020 13:20:01 +0800 From: "Zhang, Qi Z" To: "Guo, Jia" CC: "Guo, Junfeng" , "Zhang, AlvinX" , "dev@dpdk.org" , "Xing, Beilei" Thread-Topic: [PATCH v3] net/iavf: refactor RSS Thread-Index: AQHWhmfMUzcrlAGjdUS7NmPqRU2Mjalfw7rggAABElA= Date: Wed, 9 Sep 2020 05:20:00 +0000 Message-ID: <33ed2dbd6f834071957f40d272f044d5@intel.com> References: <20200909051615.33754-1-qi.z.zhang@intel.com> <7296c0f7e025446d8f95af7d3e006565@intel.com> In-Reply-To: <7296c0f7e025446d8f95af7d3e006565@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/iavf: refactor RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Guo, Jia > Sent: Wednesday, September 9, 2020 1:16 PM > To: Zhang, Qi Z > Cc: Guo, Junfeng ; Zhang, AlvinX > ; dev@dpdk.org; Xing, Beilei > Subject: RE: [PATCH v3] net/iavf: refactor RSS >=20 > Acked-by: Jeff Guo >=20 > Best regards, > Jeff Guo >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, September 9, 2020 1:16 PM > > To: Guo, Jia > > Cc: Guo, Junfeng ; Zhang, AlvinX > > ; dev@dpdk.org; Xing, Beilei > > ; Zhang, Qi Z > > Subject: [PATCH v3] net/iavf: refactor RSS > > > > Current RSS implementation is not easy to scale and maintain. > > The patch refactor the code base on below design: > > > > 1. iavf_pattern_match_item->input_set_mask is the superset of > > ETH_RSS_xxx. > > 2. iavf_pattern_match_item->meta is the virtchnl_proto_hdrs template. > > 3. iavf_hash_parse_pattern will generate pattern hint. > > 4. iavf_hash_parse_action will refine the virtchnl_proto_hdrs base on > > pattern hint and ETH_RSS_xxx. > > 5. The refine process include > > 1) refine field selector of l2, l3, l4. > > 2) insert gtpu proto_hdr at the beginning base on pattern hint. > > 3) refine field selector for gtpu header. > > > > The patch reduce the code from 4000+ line to less than 1000. > > > > Note: > > The variable iavf_hash_pattern_list as the manifest of all supported > > pattern is intend to break the 80 char limitation for better review > > experience. > > > > Signed-off-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi