From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BB0CA00C5; Thu, 15 Sep 2022 12:21:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B38F4021D; Thu, 15 Sep 2022 12:21:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6003440156 for ; Thu, 15 Sep 2022 12:21:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663237286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3QIJMFxVXkh2o0zPFvUeozjlmOqzqxOpxvaHbrCFcyg=; b=PU909vLoYut9ldF/2l2krFBLrOEpDTB0Suu1Yfid7TTH+WVwI5YXTB/ArieKp1xHx7Pqpe JrKjwuEe24a5+A6dyRUxrQdmdT+IRt8fwBGT113kwbHeNkDb6Qmv0S+v5Od5oQRXZ6Ktxa y4XTOoTr624cqb1mPNuYgqINPE+JAWQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-494-IYMToiH3NhaBhQ0dPS7AwA-1; Thu, 15 Sep 2022 06:21:24 -0400 X-MC-Unique: IYMToiH3NhaBhQ0dPS7AwA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B8DA185A794; Thu, 15 Sep 2022 10:21:23 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 653E62166B26; Thu, 15 Sep 2022 10:21:22 +0000 (UTC) Message-ID: <33ee56a4-139c-b82f-3c87-379993b3ba0f@redhat.com> Date: Thu, 15 Sep 2022 12:21:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 30/37] baseband/acc100: reduce input length for CRC24B To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-31-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-31-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Input length should be reduced only for CRC24B. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 4ce4c9d218..72e46953ee 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1978,8 +1978,7 @@ acc100_dma_desc_le_fill(struct rte_bbdev_enc_op *op, > > K = (enc->basegraph == 1 ? 22 : 10) * enc->z_c; > in_length_in_bits = K - enc->n_filler; > - if ((enc->op_flags & RTE_BBDEV_LDPC_CRC_24A_ATTACH) || > - (enc->op_flags & RTE_BBDEV_LDPC_CRC_24B_ATTACH)) > + if (enc->op_flags & RTE_BBDEV_LDPC_CRC_24B_ATTACH) > in_length_in_bits -= 24; > in_length_in_bytes = in_length_in_bits >> 3; > It looks like a fix, if so should be tagged as one.