From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADD2641BC0; Fri, 3 Feb 2023 21:49:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D07042D3D; Fri, 3 Feb 2023 21:49:25 +0100 (CET) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by mails.dpdk.org (Postfix) with ESMTP id BC0D540ED4 for ; Fri, 3 Feb 2023 21:49:24 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id E0F962B06754; Fri, 3 Feb 2023 15:49:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 03 Feb 2023 15:49:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675457355; x= 1675464555; bh=mFkei+feUUf8QKtDpHTYV1vMQqztHLxi7wH/m+lhb/4=; b=i iKwAjb0njKtXbNeQO6IRqIIq2YFn8FQQEUVdpmhSFtu5rgoGQ9LgABypVBkQR/W3 CmQhaWsWoadAwRHk/Bp8tdD0YqJKYaLFuKKSGGvgsiFmesbBDsQKv8F58msqucmE 1mWX2eHO9nH20XgGBAvt6T5uMsN+D8bPpS507MqV61IgXBXKcbaxESLkxqg+K6Sn Tmgyx1UiGgOWAvVT/hyh+R7N7MHm9epJ+T2sQOEOwr6d2DsWqAybxNkWifax426u UMLCkp/pp17tNFEbxNADnliEFSK8H9NlIqV2O6AG5s6hguk6F/2DdZPca/G0ReSE L0ObdsyUbb7VJOzODL5eQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675457355; x= 1675464555; bh=mFkei+feUUf8QKtDpHTYV1vMQqztHLxi7wH/m+lhb/4=; b=l R7L8STYCWUNeA3w2bvhqpElw9pagjiMGMtex6fWPSDbrCXa7EQIXYTaZoxYCObj/ zoskhnwoH/fB64o3s+ieUyAkeRt+SoQxb4dRR2RqDq3GcD4jjman3EYYVrIVrKG4 lvK7R73pMhxzz+v+QbQILkVAmP7DGYVCuWey6ANd5DOwTQXJVXgEXUfNFFvPDXO8 hq4eJ0XbEZj2Ply++XlGLQJMlgLZq95F8g2uD/QXax0a+UT7ewZzNnkcLecj/SnI oAO9GC0eLGcDetkwjElEmpIv1cXkZPyFxQoeNNavQUZZ57uXJtN6mRyO+psZpABC exyMKZzYqVEl6t2Hz/Ukw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegtddgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Feb 2023 15:49:04 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: Shivah Shankar Shankar Narayan Rao , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Bruce Richardson , Srikanth Yalavarthi , "ferruh.yigit@xilinx.com" , "ajit.khaparde@broadcom.com" , "aboyer@pensando.io" , "andrew.rybchenko@oktetlabs.ru" , "beilei.xing@intel.com" , "chas3@att.com" , "chenbo.xia@intel.com" , "ciara.loftus@intel.com" , Devendra Singh Rawat , "ed.czeck@atomicrules.com" , "evgenys@amazon.com" , "grive@u256.net" , "g.singh@nxp.com" , "zhouguoyang@huawei.com" , "haiyue.wang@intel.com" , Harman Kalra , "heinrich.kuhn@corigine.com" , "hemant.agrawal@nxp.com" , "hyonkim@cisco.com" , "igorch@amazon.com" , Igor Russkikh , "jgrajcia@cisco.com" , "jasvinder.singh@intel.com" , "jianwang@trustnetic.com" , "jiawenwu@trustnetic.com" , "jingjing.wu@intel.com" , "johndale@cisco.com" , "john.miller@atomicrules.com" , "linville@tuxdriver.com" , "keith.wiles@intel.com" , Kiran Kumar Kokkilagadda , "oulijun@huawei.com" , Liron Himi , "longli@microsoft.com" , "mw@semihalf.com" , "spinler@cesnet.cz" , "matan@nvidia.com" , "matt.peters@windriver.com" , "maxime.coquelin@redhat.com" , "mk@semihalf.com" , "humin29@huawei.com" , Pradeep Kumar Nalla , Nithin Kumar Dabilpuram , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , Radha Chintakuntla , "rahul.lakkireddy@chelsio.com" , Rasesh Mody , "rosen.xu@intel.com" , "sachin.saxena@oss.nxp.com" , Satha Koteswara Rao Kottidi , Shahed Shaikh , "shaibran@amazon.com" , "shepard.siegel@atomicrules.com" , "asomalap@amd.com" , "somnath.kotur@broadcom.com" , "sthemmin@microsoft.com" , "steven.webster@windriver.com" , Sunil Kumar Kori , "mtetsuyah@gmail.com" , Veerasenareddy Burru , "viacheslavo@nvidia.com" , "xiao.w.wang@intel.com" , "cloud.wangxiaoyun@huawei.com" , "yisen.zhuang@huawei.com" , "yongwang@vmware.com" , "xuanziyang2@huawei.com" , Prasun Kapoor , Nadav Haklai , Satananda Burla , Narayana Prasad Raju Athreya , Akhil Goyal , "mdr@ashroe.eu" , "dmitry.kozliuk@gmail.com" , "anatoly.burakov@intel.com" , "cristian.dumitrescu@intel.com" , "honnappa.nagarahalli@arm.com" , "mattias.ronnblom@ericsson.com" , "ruifeng.wang@arm.com" , "drc@linux.vnet.ibm.com" , "konstantin.ananyev@intel.com" , "olivier.matz@6wind.com" , "jay.jayatheerthan@intel.com" , Ashwin Sekhar T K , Pavan Nikhilesh Bhagavatula , "eagostini@nvidia.com" , Derek Chickles , Parijat Shukla , Anup Prabhu , Prince Takkar , david.marchand@redhat.com Subject: Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library Date: Fri, 03 Feb 2023 21:49:02 +0100 Message-ID: <3400417.QJadu78ljV@thomas> In-Reply-To: <20230203122625.513d4c0a@hermes.local> References: <20220803132839.2747858-2-jerinj@marvell.com> <8214941.NyiUUSuA9g@thomas> <20230203122625.513d4c0a@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/02/2023 21:26, Stephen Hemminger: > On Fri, 03 Feb 2023 21:18:40 +0100 > Thomas Monjalon wrote: > > > 03/02/2023 18:33, Stephen Hemminger: > > > On Fri, 03 Feb 2023 09:42:45 +0100 > > > Thomas Monjalon wrote: > > > > > > > 03/02/2023 01:25, Stephen Hemminger: > > > > > On Wed, 1 Feb 2023 13:34:41 +0000 > > > > > Shivah Shankar Shankar Narayan Rao wrote: > > > > > > > > > > > --- a/lib/eal/include/rte_log.h > > > > > > +++ b/lib/eal/include/rte_log.h > > > > > > @@ -48,6 +48,7 @@ extern "C" { > > > > > > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > > > > > > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > > > > > > #define RTE_LOGTYPE_GSO 20 /**< Log related to GSO. */ > > > > > > +#define RTE_LOGTYPE_MLDEV 21 /**< Log related to mldev. */ > > > > > > > > > > NAK to this part. > > > > > No new static logtypes please. > > > > > > > > Good catch. > > > > By the way, we should remove unused RTE_LOGTYPE_*. > > > > > > Yes, for 23.11 would like to work down the list. > > > > Do we need to wait 23.11? > > It is not an ABI breakage. > > And most of these defines are already unused. > > Turning them into deprecated would be API breakage though API breakage is not forbidden.