From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 812D4A0A0C; Thu, 15 Apr 2021 09:54:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40E281620C4; Thu, 15 Apr 2021 09:54:17 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 4CA291620BB for ; Thu, 15 Apr 2021 09:54:15 +0200 (CEST) IronPort-SDR: k+UzYn9XUGQ3sH1niLYI7HQ+WSdjiO0I03fzd1LQHh5rOOGml5/eriHX+TCOW3APwp2VbgBRoe 32+k7rJB658g== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="258768447" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="258768447" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 00:54:14 -0700 IronPort-SDR: WKftB6HH8n0oBc+7+qhbD+y/YAc6xQpDVIFBJR9svageWfsSoaqybcQJVMo9seBLtqEzUKzApd TZaeS/Ng8gnQ== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="425082456" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.204.163]) ([10.213.204.163]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 00:54:11 -0700 From: Ferruh Yigit To: "Min Hu (Connor)" , dev@dpdk.org Cc: ajit.khaparde@broadcom.com, xiaoyun.li@intel.com, "Chen, Zhaoyan" , "Yu, PingX" , Aaron Conole , Honnappa Nagarahalli References: <1614906276-34293-1-git-send-email-oulijun@huawei.com> <1617068905-5364-1-git-send-email-humin29@huawei.com> <9bb01775-faa1-3811-43d8-bb701c2eb09c@intel.com> X-User: ferruhy Message-ID: <340dc152-6135-6a85-da51-f7a7a0c6d195@intel.com> Date: Thu, 15 Apr 2021 08:54:06 +0100 MIME-Version: 1.0 In-Reply-To: <9bb01775-faa1-3811-43d8-bb701c2eb09c@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/12/2021 5:37 PM, Ferruh Yigit wrote: > On 3/30/2021 2:48 AM, Min Hu (Connor) wrote: >> From: Lijun Ou >> >> This patch adds multi-process support for testpmd. >> The test cmd example as follows: >> the primary cmd: >> ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ >> --rxq=4 --txq=4 --num-procs=2 --proc-id=0 >> >> the secondary cmd: >> ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ >> --rxq=4 --txq=4 --num-procs=2 --proc-id=1 >> > > Hi Connor, > > Please find a few minor comments below, since they are minor issues please feel > free to keep the existing acks in next version. > Reminder of this patch, waiting for minor updates, it would be good to have it before -rc1, so that the change can be tested thoroughly. Meanwhile I have concern/question on long term testing of the feature. It is possible to break the multi-process support unintentionally and not recognize it. How can we continually verify the feature? Are you using DTS? Does it make sense to add a testcase into dts to test testpmd multi-process support so that it is verified on each release?