From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D324A1EA1A for ; Tue, 12 Jun 2018 14:26:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4FFA121DF8; Tue, 12 Jun 2018 08:26:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 12 Jun 2018 08:26:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=+CbNiG2+0gdp5tvIZnNC6ntzGA zjSZjiSxq5ee79esA=; b=IQ24yunEEPMs9/oY4SYrAXekQ384UocHnwiEsq6caK PtlGA2kuiJS4Q1nyrjcg1nOUUhhvVCmaNsBSRr+SrG/YAXih0r0+GQla6HqHcZJW cmjjCK8fNF50E/QiMgkMR9Hn7INlRUpIhhqFmUL9g2IM63r8KtduvvJo/tkVCbDh g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=+CbNiG 2+0gdp5tvIZnNC6ntzGAzjSZjiSxq5ee79esA=; b=MwFIJsf9qgpM/0RP/yj3RU thNNnsbUdRJ3H26AemNbZ/XWi/pukcfvMrqYcWpy1cWrTHDD7A5eKmfFo+y7k0GN fVSoWcC3ihVXS8WyLetrZ2LJeM5Req/3FLa4nzq8FCxQrcJCw2Y97EpX9EdOAc3/ NuSAHMXUDF2uHTSNb1w9xmcHweo9iWuS/vsjHoB1R7fRek2NaplDYhC6UMfnXiBF xVGszYkZ0+tT74fysltrKIman8niA/ewjWr+zcHXo9NaELG3GRss9T6fO3hK19fs zeVEj1SKsr/FXv0loC3c0Jd4L9ofR6IrBg3201cqwrxZIkBxY4wBbAeuf7idatRg == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5AC6810338; Tue, 12 Jun 2018 08:26:07 -0400 (EDT) From: Thomas Monjalon To: "Wiles, Keith" Cc: dev@dpdk.org, Ophir Munk , Pascal Mazon , Olga Shern Date: Tue, 12 Jun 2018 14:26:06 +0200 Message-ID: <3421596.l5OksTDFGx@xps> In-Reply-To: References: <1528733172-24747-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 12:26:09 -0000 11/06/2018 18:35, Wiles, Keith: >=20 > > On Jun 11, 2018, at 11:06 AM, Ophir Munk wrote: > >=20 > > This commit explains how to manually compile the C source file > > tap_bpf_program.c into an ELF file using the clang compiler. > > The code in tap_bpf_program.c requires definitions found in iproute2 > > source code. This commit suggests cloning the iproute2 git tree and > > include its path in the clang command. It also adds inclusion of file > > bpf_api.h (required for eBPF definitions) which is located in iproute2 > > source tree. For more details refer to TAP documentation. > > This commit is related to commits [1] and [2]. >=20 > Normally I would have suggested that eBPF be disable in the TAP driver as= it requires external code and programs, but that ship has sailed. The external programs are required only to generate new instructions, changing the behaviour of the BPF program. Currently, the instructions for RSS behaviour are provided. > I would like to see building the tap_bpf_program.o as a target in the Mak= efile, this way the developer can just run the =E2=80=98make bpf_program=E2= =80=99 target and it would be simpler and less error prone. =46or this to happen, we need to improve the tools. It is a work in progress. This is a very first step to use Linux BPF with DPDK. If there are more interests, we should really streamline its usage for all parts of DPDK which runs on top of some kernel code.