From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42A09A0561; Mon, 20 Apr 2020 18:10:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E70141D5B4; Mon, 20 Apr 2020 18:10:32 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 445F41D5A1 for ; Mon, 20 Apr 2020 18:10:30 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id AEE495803C3; Mon, 20 Apr 2020 12:10:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 20 Apr 2020 12:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 9yarWeBNJQRX8ZW7Y2g7Oazn+EZbYdWeZBZKdmnVhaA=; b=fhXWweI+yzol2kBd JXjpMRBDzgrooZMctJJdx5ezjlhes63+WGF8MY6SKDZmn9LHBICw1LxsXY1jupWd wlJltHe2yOsakCRgn56GJ+/J353BxbZVeMomQailu6FaQK3Sm4A3QtAMXYQbXz0N JaOZ75mTAluNzDOW4yvlYHmiV4Q9dlUBysVXOqFg40hxnWkLlq8RDw9IHnXEvEr+ gnz5fO0zDw0eoRZJvcSqzdNsmmosfIaFChR9V0TEYAw+Vfb9iyZqTALDjHL+C5Gs Wy4db+6GGkrBDTDrAZSHj82xoB6/9329IipbjtBOoKqSdgOd7e9vqTUHx+JeAFKw iB9baQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9yarWeBNJQRX8ZW7Y2g7Oazn+EZbYdWeZBZKdmnVh aA=; b=C0Pm5/uFqR7gOoebCQvvXLXvNlVDvVqJfANpEmMc85jNFre0pfoyXLYOP 7/3lpZEqRWnc6t1xw546oyrYdSNErihnjXeWB8UDM+tk/xNC6NJaWibRXS3zEdIo INxPCFwlgqRnjUwqYzldnCcI8zvG8QqwPdpyU4df+84hGMvA7nrbDyUi8cULtQoC mOmRgSpT9kL5fMV3Rat1KBt4RPpBtscQVgAJG06aa3U2u0m7Hqc8ZQF+U3Lbtbbr rkXxXVS878IQGQtYADcyAk90xJBXZdTpi0z4zb9lXf97Z31XLHIpmPSOevb5Qap4 G+pJQXCiGKW2Resp2nbAYK/jVa6pw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeefgdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BFB56328006B; Mon, 20 Apr 2020 12:10:27 -0400 (EDT) From: Thomas Monjalon To: Bill Zhou , Ferruh Yigit Cc: Ori Kam , Matan Azrad , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , "arybchenko@solarflare.com" , dev@dpdk.org Date: Mon, 20 Apr 2020 18:10:26 +0200 Message-ID: <3422085.0RtB02Ng89@thomas> In-Reply-To: References: <20200410094631.31330-1-dongz@mellanox.com> <4860948.CpGBqz00pN@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/04/2020 16:06, Ferruh Yigit: > On 4/18/2020 10:44 AM, Thomas Monjalon wrote: > > 18/04/2020 07:04, Bill Zhou: > >> From: Ferruh Yigit > >>> On 4/14/2020 9:32 AM, Dong Zhou wrote: > >>>> --- a/lib/librte_ethdev/rte_ethdev.h > >>>> +++ b/lib/librte_ethdev/rte_ethdev.h > >>>> @@ -3015,6 +3015,7 @@ enum rte_eth_event_type { > >>>> RTE_ETH_EVENT_NEW, /**< port is probed */ > >>>> RTE_ETH_EVENT_DESTROY, /**< port is released */ > >>>> RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */ > >>>> + RTE_ETH_EVENT_FLOW_AGED,/**< New aged-out flows is detected > >>> */ > >>>> RTE_ETH_EVENT_MAX /**< max value of this enum */ > >>>> }; > >>> > >>> > >>> Just recognized that this is failing in ABI check [1], as far as last time for a > >>> similar enum warning a QAT patch has been dropped, should this need to > >>> wait for > >>> 20.11 too? > >> > >> This patch is commonly used for flow aging, there are 2 other patches have > >> implement flow aging in mlx5 driver reply to this patch. [...] > > These MAX values in enums are a pain. > > We can try to think what can be done, waiting 20.11. > > Not sure there is a solution, except hijacking an existing value > > not used in the PMD, waiting the definitive value in 20.11... > > Dropping from the tree as of now, to not cause more merge conflicts, we can add > it later when issue is resolved. Thanks for dropping, that's the right thing to do when a patch is breaking ABI check. After some thoughts, I think it is acceptable to make a v3 which ignore this specific enum change. I explain my thought below: An enum can accept a new value at 2 conditions: - added as last value (not changing old values) - new value not used by existing API The value RTE_ETH_EVENT_FLOW_AGED meet the above 2 conditions: - only RTE_ETH_EVENT_MAX is changed, which is consistent - new value sent to the app only if the app registered for it So, except if I miss something, I suggest we add this exception: Allow new value in rte_eth_event_type if added just before RTE_ETH_EVENT_MAX. In other words, allow changing the value of RTE_ETH_EVENT_MAX. The file to add such exception is devtools/libabigail.abignore.