From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 0DB4A37AF for ; Sun, 1 Nov 2015 15:58:22 +0100 (CET) Received: by wicll6 with SMTP id ll6so36043223wic.0 for ; Sun, 01 Nov 2015 06:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=FMltK1YPjGvpMBUxDwG4jpWhYnSTwK2lBslR3/4jhQo=; b=G734aFwIuik0Q5VjrN0GGe3eZ+eNP/OjnTD9c7A9YCvKARbkQ92wnZYUeJJQ6XlNHO maJ8bbOwZq6w9TfHJI8bYrRnACUwiPPWIOn/jssML5u4xBDTCIYTSe82LqiRAhg2GCyq FtCxAbgdza1LrfgnGBrV+T0QTo04yC33mnDqqyEHuCvRG2MZfnsrVBzgAXH5P4IHZQvO QRSs6w0fQyUbZouzy9Ozc94Ne8IszG6T/pQRKDmAHZtZA4DFIP/tJMnIUs+YFHX+b5ic kTOEWRcRDaZ4MgbjbWB3s0Jr6Qgyw6Iw7NRms3pvSZBjzwhSL6kgNGpQ7iS68dbEPkfb oThQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=FMltK1YPjGvpMBUxDwG4jpWhYnSTwK2lBslR3/4jhQo=; b=G1Dru0sNh22SnUCGHVMYv+ejev8rfSKgub10VAfmNk2VLCW1At6CNMKVa1bS7pjlcz 9zr5PhTJDE/xB+qkvoQsIGtStAAi8z2fNwHKmRae9sjEwD0d6ZCt9jE+pbW79UOGoizo YRFoaQWBUVQzXCUr/CVMES/7SoG1QtOeWMba3F/IJ4hVoJelnM7exM6gf5Ka4YyRmHvb lJXo4W96GW9yTMwXbne/3sWfqQQKqGuznOgY1SXTCJvXTU5IDIQ3HkQgKtbQTDb8lPA5 D7XNCakZ2S5GmGNscijoew5Q407ItL0JVKg5q52iYMjC7bCLNiVTtSWOPRIfBAUdRIbk jRRQ== X-Gm-Message-State: ALoCoQnJW7BYHx5mg8lQk4a9DV4IEFNxqPM5Y310OTVukX0aMSv7xFxKA7pbQ9mToDq9K3VI5fA3 X-Received: by 10.194.179.165 with SMTP id dh5mr22081217wjc.134.1446389901889; Sun, 01 Nov 2015 06:58:21 -0800 (PST) Received: from xps13.localnet (59.26.90.92.rev.sfr.net. [92.90.26.59]) by smtp.gmail.com with ESMTPSA id q1sm17351995wje.39.2015.11.01.06.58.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Nov 2015 06:58:21 -0800 (PST) From: Thomas Monjalon To: "Wu, Jingjing" Date: Sun, 01 Nov 2015 15:55:42 +0100 Message-ID: <3422621.OhOAmi5lFO@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8D0F1EC@SHSMSX104.ccr.corp.intel.com> References: <1446021688-17544-1-git-send-email-jingjing.wu@intel.com> <7872129.vXpfkMljjd@xps13> <9BB6961774997848B5B42BEC655768F8D0F1EC@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support flow director in VFs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 14:58:22 -0000 2015-11-01 14:33, Wu, Jingjing: > Hi, Thomas > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Sunday, November 1, 2015 10:28 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support flow director in VFs > > > > 2015-11-01 00:24, Jingjing Wu: > > > This patch extends struct rte_eth_fdir_flow_ext to support flow > > > director in VFs. > > [...] > > > --- a/lib/librte_ether/rte_eth_ctrl.h > > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > > @@ -426,6 +426,8 @@ struct rte_eth_fdir_flow_ext { > > > uint16_t vlan_tci; > > > uint8_t flexbytes[RTE_ETH_FDIR_MAX_FLEXLEN]; > > > /**< It is filled by the flexible payload to match. */ > > > + uint8_t is_vf; /**< 1 for VF, 0 for port dev */ > > > + uint16_t dst_id; /**< VF ID, available when is_vf is 1*/ > > > }; > > > > Why adding these parameters in an input struct? > > Shouldn't it be in rte_eth_fdir_action along with rx_queue? > Thanks for your comments. The reason of adding these in input is because this is input but not action. > The patch is to support Flow director works in VF, then direct packets to the rx_queue (belong this vf) > which defined in action, but not direct packets to VF. Oh! >>From the VM, using rte_eth_dev_filter_ctrl(port_id, filter_type, filter_op, arg) it can be deduced from the VF device, no? Is the use case to define a VF flow director outside of the VM?