From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 995D742DC3; Mon, 3 Jul 2023 17:44:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86EEC42BFE; Mon, 3 Jul 2023 17:44:20 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 73985410DC; Mon, 3 Jul 2023 17:44:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 194125C0213; Mon, 3 Jul 2023 11:44:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 03 Jul 2023 11:44:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688399058; x=1688485458; bh=uxxMm4Avxr9CbricyaZw8I7RnspHn2vWUFn Ju9AT2wQ=; b=BwUVGeWUoSj/J1akMoDGo2XjyaOH2ATc7gzRxwZg1udKiC84d5y Mry8gtgBIkx092BqtBMW7es/NjyLWsPOFrkNfwr8+G0SEoTM3H68nRRGB2pG/JZu uQ88w9E5sWfhO2vNTHP3uqDZcN8sfSrKmoiAnSBmdSi57FlpPEJ5pfhGhvJWxx0Y 4+xKSY0wVOuIokka6sC4flN9qrROUtRidhtvEXTMRTu7Jrm2M8L0lH2OdKd7b3gn w0h2m6rFv0710Rm15NKEIOL/RiITEV7H70eNdQdxBZZoNz362mbuCNqYcWI9sxH9 p56laIrgyvsmDH1ef4IoTRA5OJvDaU2O/iQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688399058; x=1688485458; bh=uxxMm4Avxr9CbricyaZw8I7RnspHn2vWUFn Ju9AT2wQ=; b=BQwVt257hSIlXNTfs+N8NCKVJoIbjwdA5O9QUgjhmP2Hi5N/ivt rDwpQotvWE+kA1t9ozRMXiIqZhXZLFFd72GZ8P8iYl9l5hUYxSTPELV4bxj8d7So JhKl8SG/x5ca9uHgAwVaJfB0ldMN5cOi/CNQFg8vflLfd7wrwFUGFp/jA94wtVpF ZuMkMffsU6pW8blDJKSqnwqdFCOPDGeuhLgm6gd1wBijNFpuEEBSGC1DF7IA+EZN +KLqCmfkl/ijxTY4bzqxT4jWG9dX0KmOmcUONAgugFi3NbiMqjB6+ojE3mPAKNY/ q4NS75XiRIRRObS87uQGlmZOILuqa2Lp61Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Jul 2023 11:44:16 -0400 (EDT) From: Thomas Monjalon To: "Guo, Junfeng" Cc: stable@dpdk.org, "dev@dpdk.org" , "stable@dpdk.org" , "He, Xingguang" , "Laatz, Kevin" , "Wu, Jingjing" Subject: Re: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops Date: Mon, 03 Jul 2023 17:44:15 +0200 Message-ID: <3426428.QJadu78ljV@thomas> In-Reply-To: References: <20230614051423.176572-1-junfeng.guo@intel.com> <20230628091218.32292-1-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/07/2023 08:53, Wu, Jingjing: > > > -----Original Message----- > > From: Guo, Junfeng > > Sent: Wednesday, June 28, 2023 5:12 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; stable@dpdk.org; He, Xingguang ; Laatz, Kevin > > ; Guo, Junfeng > > Subject: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops > > > > During EAL cleanup stage, all bus devices are cleaned up properly. > > In the meantime, the ntb example app will also do the device cleanup > > process, which may call the dev ops '*dev->dev_ops->dev_close' twice. > > > > If this dev ops for ntb was called twice, the interrupt handle for > > EAL will be disabled twice and will lead to error for the seconde > > time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx" > > > > Thus, this patch added the check process for disabling interrupt in > > dev_close ops, to ensure that interrupt only be disabled once. > > > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > > Cc: stable@dpdk.org > > > > Signed-off-by: Junfeng Guo > > Acked-by: Jingjing Wu Applied, thanks.