From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F9BDA00C5; Tue, 15 Feb 2022 14:45:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5C364113E; Tue, 15 Feb 2022 14:45:29 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 92949410F7 for ; Tue, 15 Feb 2022 14:45:28 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E579A5C0353; Tue, 15 Feb 2022 08:45:27 -0500 (EST) Received: from imap48 ([10.202.2.98]) by compute2.internal (MEProxy); Tue, 15 Feb 2022 08:45:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=YV3Cls3mYwejy0j9MGqrqyM3G6Ki252kvGus1J KwTew=; b=J1CvgQgkfnqvg/Kt978RGOT/tIbhwwzDkHCBXVwIq1k4yYeSOtfXbr 0/NLXZOP/3ER6cyvc7MuRWtLmb2Mc/pkCaMmVazvweBBYS+m5i+z3yOyke98I6uv R756B1YPLVjrhewckXyKfLDrTu0D5U9zbPaV+UmuH9rOaWTIR9YQo2IEwJboC/SG ZIQjGgWokaBrm8xGHxTkWt0AyMGBlur5wtdK4hX2nPdlF3z1F8FUg951dXy6utDw AVwinFrD2ZyyGlks3mHANGbZD7Rcf6hO0hbK/BWIkVhaHFWUBhFta1d+heQMz9lt kTg7y9vXdZjpXqz305RkT+Us6AjKQxaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=YV3Cls3mYwejy0j9M GqrqyM3G6Ki252kvGus1JKwTew=; b=IdKLhZHbQwlulMxvvt49DrTQtokXMbBd0 PMl4khq/VqsfQLmXWvYiSzQl+yQUvwiFCBBbKJwvyWT2PSVu9nQ62WUWLjhRJA3Q O7228OEi59aVbbQIAR96GFi5XKe3fJbu45O6nowYATq6QCppJ/iefWyh8u7nLjXm 83vfDj1cIi9WLWKSqEzqe669WB/fQ4kmRhBELEWuQ/O/XxsvXw+2lvQxLXV5VXCU vQFTCooN1IfM0BaNrXO6jvMRJLOnUmgacukyl9bTBMdVMadeR9ivf5LYXES+sk9k R5NVz0RdbEwdw6nmd6Xyfw+eWWx4yHhd2g/RkfHR0MuF8AdVMm+Lg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjeeggdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpefirgotthgr nhgptfhivhgvthcuoehgrhhivhgvsehuvdehiedrnhgvtheqnecuggftrfgrthhtvghrnh epgfeuhfffleeludeuheeuteeufeegtdeiveduudfhgeevteeutdelueffueehkeefnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrihhvvg esuhdvheeirdhnvght X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8279521E0073; Tue, 15 Feb 2022 08:45:27 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4748-g31a5b5f50e-fm-cal2020-20220204.001-g31a5b5f5 Mime-Version: 1.0 Message-Id: <3429057a-8c92-4c1c-a757-847094c007c4@www.fastmail.com> In-Reply-To: References: <20220210071052.527-1-madhuker.mythri@oracle.com> <20220210170131.2199922-1-grive@u256.net> Date: Tue, 15 Feb 2022 14:45:07 +0100 From: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= To: "Ferruh Yigit" , dev@dpdk.org Cc: "madhuker.mythri" Subject: Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 15, 2022, at 13:51, Ferruh Yigit wrote: > On 2/10/2022 5:01 PM, Gaetan Rivet wrote: >> The function rte_devargs_parse() previously was safe to call with >> non-initialized devargs structure as parameter. >> >> When adding the support for the global device syntax, >> this assumption was broken. Restore it by forcing memset as part of >> the call itself. >> >> Bugzilla Id: 933 >> Fixes: b344eb5d941a ("devargs: parse global device syntax") >> Signed-off-by: Gaetan Rivet > > Reported-by: Madhuker Mythri > > Since Madhuker did the initial analysis and the patch > I think fair to give credit for the work. > > Thanks, > ferruh > Sure, thanks Ferruh. Whichever patch is fine by me. -- Gaetan Rivet