From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 2032F568E for ; Mon, 27 Jun 2016 16:59:44 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id f126so104154160wma.1 for ; Mon, 27 Jun 2016 07:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=xNACSyEFQRSdkTH74LP/wjxGJyqozn6bLRLgsa+cIr4=; b=sjEUvpI9epJy/abF2cS/xLVHHhahWUqOFHZugPs5RJ1A+QN3xISV5/JYzXBiDZEmHw cazncNcQaCfyjYEzrfmu7BWSKsq/DKe/lZ/++QshsHcF+D4pfHrZ9DFkcgb3N7bzuXyK 3kAK3neImFa3NCmipZUzRINiXqrXFjjcIjtyjC2ZtdXx2UA/RV9L8Q9HzKssH8sESq+8 rTJlQ/HqdogdDpKEf1jkTHWZvok73InmnAuJdWWhzTi0S4Fcy99FTQaKHaqBxFh0+KcR VXsYcO23qdUge3k2MW//37gXZY3KhpQGLN2UIPhb4fWdSobNV2AtK6GZcin9V1QFV4rd jRvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=xNACSyEFQRSdkTH74LP/wjxGJyqozn6bLRLgsa+cIr4=; b=fQ6zwPXPVoxrguAbDXZ2tV4Xu1mHP4GNjiRuIl3qZrWHs+gGJvBz+uxaOGDNOSnANW Pv+iTCrje7iTIOwm6G75WBHXH73EwJtsaTiqSp8E+3bp4zLwjtXa+NgbKPZcg+jihr5g Qp0YfhsesiOes46PqYUbjqGz8wEUtUrm0QmUwV8DPPC0BlkhP8iDtDNKO3ndCMobWWvY w+5XpiVkh1yqmbptje9GGLKBte0/zfsxLCxt3e/jrlX1DIVtWcmIuwzKehfT7EhG5C0P nWovEVfHt+SgG74Qk0lthdiU3S51YGZBgi9g4kU8Zeo188dlVnLQCEcLhj7lJmq06BRI 2skg== X-Gm-Message-State: ALyK8tKQExozGanns6LbXLzXDdiYm3jVRWk1A1WdxFwoqlsWToWfEqcoiFoSnCrABX/Mw1mc X-Received: by 10.194.82.36 with SMTP id f4mr1336857wjy.104.1467039583937; Mon, 27 Jun 2016 07:59:43 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id kd7sm1182077wjc.33.2016.06.27.07.59.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 07:59:43 -0700 (PDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, jianbo.liu@linaro.org, huawei.xie@intel.com, yuanhan.liu@linux.intel.com Date: Mon, 27 Jun 2016 16:59:42 +0200 Message-ID: <3436400.asiby3BQPB@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160627144829.GA25422@localhost.localdomain> References: <1467028448-8914-1-git-send-email-jerin.jacob@caviumnetworks.com> <2275187.xVvf3fOqxc@xps13> <20160627144829.GA25422@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/4] virtio: introduce RTE_LIBRTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 14:59:44 -0000 2016-06-27 20:18, Jerin Jacob: > On Mon, Jun 27, 2016 at 04:19:57PM +0200, Thomas Monjalon wrote: > > 2016-06-27 17:24, Jerin Jacob: > > > --- a/config/common_base > > > +++ b/config/common_base > > > @@ -267,6 +267,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n > > > +CONFIG_RTE_LIBRTE_VIRTIO_INC_VECTOR=y > > > > I don't remember what means INC_VECTOR? > > Why a config option is needed for vector implementations? > > I thought of adding additional configuration option(INC_VECTOR) _apart_ from > cpu flag based scheme in the patch because even though if a given platform > has cpu instruction support, in some platforms scalar version may > perform well wrt vector version(based on instruction latency, emulation required or not > etc). So a top level flag INC_VECTOR, can override the vector selection > for a given platform if required. Isn't it a runtime driver option needed to disable vector virtio? > Regarding INC_VECTOR(INC in vector configuration name, I have no idea, I > followed the existing flags) > $ grep "INC_VECTOR" config/common_base > CONFIG_RTE_IXGBE_INC_VECTOR=y > CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y > CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y If the flag is really needed I would suggest VIRTIO_VECTOR.