DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] usertools: enhance device bind script module detection
@ 2019-09-21 18:16 pbhagavatula
  2019-10-27 20:20 ` Thomas Monjalon
  2019-11-02 14:23 ` [dpdk-dev] [PATCH v2] " pbhagavatula
  0 siblings, 2 replies; 4+ messages in thread
From: pbhagavatula @ 2019-09-21 18:16 UTC (permalink / raw)
  To: jerinj; +Cc: dev, Pavan Nikhilesh, Phanendra Vukkisala

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Some kernel modules have '-' in their name when populated in
'/sys/bus/pci/drivers/' where as the kernel always populates
'/sys/modules/' with '_'.
Replace '-' in module name with '_' to avoid script complaining
that module not loaded.

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 usertools/dpdk-devbind.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 7b5cbc12c..b1d149876 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -153,6 +153,9 @@ def check_output(args, stderr=None):
 def module_is_loaded(module):
     global loaded_modules
 
+    if module == 'vfio_pci':
+        module = 'vfio-pci'
+
     if loaded_modules:
         return module in loaded_modules
 
@@ -520,7 +523,7 @@ def bind_all(dev_list, driver, force=False):
         pass
 
     # check if we're attempting to bind to a driver that isn't loaded
-    if not module_is_loaded(driver):
+    if not module_is_loaded(driver.replace('-','_')):
         sys.exit("Error: Driver '%s' is not loaded." % driver)
 
     try:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection
  2019-09-21 18:16 [dpdk-dev] [PATCH] usertools: enhance device bind script module detection pbhagavatula
@ 2019-10-27 20:20 ` Thomas Monjalon
  2019-11-02 14:23 ` [dpdk-dev] [PATCH v2] " pbhagavatula
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-10-27 20:20 UTC (permalink / raw)
  To: pbhagavatula, Phanendra Vukkisala; +Cc: dev, jerinj

21/09/2019 20:16, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Some kernel modules have '-' in their name when populated in
> '/sys/bus/pci/drivers/' where as the kernel always populates
> '/sys/modules/' with '_'.
> Replace '-' in module name with '_' to avoid script complaining
> that module not loaded.

Sorry it does not look obvious to me.
Please, could you describe what is wrong and what is the real cause?



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH v2] usertools: enhance device bind script module detection
  2019-09-21 18:16 [dpdk-dev] [PATCH] usertools: enhance device bind script module detection pbhagavatula
  2019-10-27 20:20 ` Thomas Monjalon
@ 2019-11-02 14:23 ` " pbhagavatula
  2019-11-26 22:55   ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: pbhagavatula @ 2019-11-02 14:23 UTC (permalink / raw)
  To: thomas, jerinj; +Cc: dev, Pavan Nikhilesh, Phanendra Vukkisala

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Some kernel modules use '-' in their name when registering through
`pci_register_driver` and the same name  is populated in
'/sys/bus/pci/drivers/'.
But the kernel always populates modules names replacing '-' with '_'
in '/sys/module/'.

Example:
	# ./usertools/dpdk-devbind.py -b octeontx2-nicpf 0002:03:00.0
	Error: Driver 'octeontx2-nicpf' is not loaded.

	# ls /sys/bus/pci/drivers/octeontx2-nicpf
	bind  module  new_id  remove_id  uevent  unbind
	# ls /sys/module/octeontx2_nicpf/
	drivers  uevent  version

The patch addresses it by always replacing '-' with '_' when looking in
'/sys/module/'

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 usertools/dpdk-devbind.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 7b5cbc12c..b1d149876 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -153,6 +153,9 @@ def check_output(args, stderr=None):
 def module_is_loaded(module):
     global loaded_modules
 
+    if module == 'vfio_pci':
+        module = 'vfio-pci'
+
     if loaded_modules:
         return module in loaded_modules
 
@@ -520,7 +523,7 @@ def bind_all(dev_list, driver, force=False):
         pass
 
     # check if we're attempting to bind to a driver that isn't loaded
-    if not module_is_loaded(driver):
+    if not module_is_loaded(driver.replace('-','_')):
         sys.exit("Error: Driver '%s' is not loaded." % driver)
 
     try:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] usertools: enhance device bind script module detection
  2019-11-02 14:23 ` [dpdk-dev] [PATCH v2] " pbhagavatula
@ 2019-11-26 22:55   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-11-26 22:55 UTC (permalink / raw)
  To: pbhagavatula; +Cc: dev, jerinj, Phanendra Vukkisala

02/11/2019 15:23, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Some kernel modules use '-' in their name when registering through
> `pci_register_driver` and the same name  is populated in
> '/sys/bus/pci/drivers/'.
> But the kernel always populates modules names replacing '-' with '_'
> in '/sys/module/'.
> 
> Example:
> 	# ./usertools/dpdk-devbind.py -b octeontx2-nicpf 0002:03:00.0
> 	Error: Driver 'octeontx2-nicpf' is not loaded.
> 
> 	# ls /sys/bus/pci/drivers/octeontx2-nicpf
> 	bind  module  new_id  remove_id  uevent  unbind
> 	# ls /sys/module/octeontx2_nicpf/
> 	drivers  uevent  version
> 
> The patch addresses it by always replacing '-' with '_' when looking in
> '/sys/module/'
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Applied, thanks for the clear explanation.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-21 18:16 [dpdk-dev] [PATCH] usertools: enhance device bind script module detection pbhagavatula
2019-10-27 20:20 ` Thomas Monjalon
2019-11-02 14:23 ` [dpdk-dev] [PATCH v2] " pbhagavatula
2019-11-26 22:55   ` Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox