From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90109A04DE; Tue, 26 Nov 2019 23:55:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 62F183195; Tue, 26 Nov 2019 23:55:24 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 40CBB2C60 for ; Tue, 26 Nov 2019 23:55:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C7A4722787; Tue, 26 Nov 2019 17:55:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Nov 2019 17:55:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=mZVX4Kxua6Kwvm5SyKM2FvkKZ1w64xkntK6n9Qz0Goc=; b=fLerRA3ayYaP 8jneatrERI4fqdp1iGwMyFK/Djl4dtl8BkDhvqCaHtzq3UaeodZJNGwBV27y4gEd KjPxYYetLAbuVmQaHpJ32+CbDuEjxEOKWWVbZPnresVAlWrhkVrsMzFXWy8kIwqw Ja5zH5/006KYvOydqtv1JErFDtXvJD4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mZVX4Kxua6Kwvm5SyKM2FvkKZ1w64xkntK6n9Qz0G oc=; b=nyzy0oUQbO7FeuWLoSeBE+PJ3yg1U4pTm94NQJQRsAmbqrmTu7xq1nJfP MMM3kYKCJWbK2tQ9slmYI5VId2XpVuY+GZ4LI4bo6GJXZ4Tkw+RweiSPOdJ4MShI XXWFtdj4+7MvA9U/Uyk0QScy0GJS17UkoSKrPwqCs+qW3hFXQltLhz2GU8A9f/ow 1s7FV5iP3ztNcOR/6IL+r3IZ+6RFC+VnxyS3gYqAkcb0NEsbFvQWxis3wCYSR5Tj GeCYsrBiwbF0rveiOySGul3yZNXWwrA2Er7S13Ooci35K/DOSeRmAZw3C+Pq85xp m7bXGBAV6AM3thBZJR4mWWm6/8K+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeigedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehlohgruggvugdrlhhsnecukfhppeejjedrudefgedrvddtfedrudekgeen ucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth enucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DCD3A8005A; Tue, 26 Nov 2019 17:55:21 -0500 (EST) From: Thomas Monjalon To: pbhagavatula@marvell.com Cc: dev@dpdk.org, jerinj@marvell.com, Phanendra Vukkisala Date: Tue, 26 Nov 2019 23:55:20 +0100 Message-ID: <3439238.TMZgjuWe3e@xps> In-Reply-To: <20191102142316.750-1-pbhagavatula@marvell.com> References: <20190921181626.13034-1-pbhagavatula@marvell.com> <20191102142316.750-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] usertools: enhance device bind script module detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2019 15:23, pbhagavatula@marvell.com: > From: Pavan Nikhilesh > > Some kernel modules use '-' in their name when registering through > `pci_register_driver` and the same name is populated in > '/sys/bus/pci/drivers/'. > But the kernel always populates modules names replacing '-' with '_' > in '/sys/module/'. > > Example: > # ./usertools/dpdk-devbind.py -b octeontx2-nicpf 0002:03:00.0 > Error: Driver 'octeontx2-nicpf' is not loaded. > > # ls /sys/bus/pci/drivers/octeontx2-nicpf > bind module new_id remove_id uevent unbind > # ls /sys/module/octeontx2_nicpf/ > drivers uevent version > > The patch addresses it by always replacing '-' with '_' when looking in > '/sys/module/' > > Signed-off-by: Phanendra Vukkisala > Signed-off-by: Pavan Nikhilesh Applied, thanks for the clear explanation.